Improve notification content #4662
Conversation
Change an if to a switch to match the one below.
Add the room's title to bestAttemptContents.
…or member displayname and avatar changes.
…not be a message.
|
@niquewoodhouse All the strings I've changed/added are available in the description. What do you think about including the file name such as for
It may make more sense for these to be left off or to separate them with a colon?
|
File names can be really helpful because they set expectations for what you'll see when you open a file. But that depends completely on files being well named. In the proposal, if I send a video from Photos, is the name of the video shown? |
Sadly, yes it will be. Just checking now, it seems we rename the file to "Video" before sending which results in this lovely notification: For reference the notification for a photo from the photos library: Also, might be worth bearing in mind that the next part of #4132 is to investigate fetching thumbnails that can be attached to the notification. |
|
Although thinking about this, technically that isn't us renaming the file, and more that in this instance we've chosen (on Element iOS) to include the message "Video" instead of the filename when sending a video. |
|
😃 |
This reverts commit ee059e2.
|
📱 Scan the QR code below to install the build for this PR. If you can't scan the QR code you can install the build via this link: https://i.diawi.com/auYHgq |
|
@niquewoodhouse Changes made 👍 |
Set notificationBodyLocalizationKey in CommonConfiguration. Remove redundant customisation. Use MXRoomMemberEventContent.
Fixes #4659, #4653 and #4660. Name/Avatar changes need testing.
Depends on matrix-org/matrix-ios-kit#882.
In every case where an event's type is unclear, "Notification" will now be shown instead of "Message" with the room's name as the title when possible:
(The one exception to this is if the extension is killed/crashes, in which case "Message" will remain as the notification sent from the server).
New body strings introduced
Reply title strings