Fix redirection issue when logging in with single sign on. Fixes #4785.

[pengufrost]

Fixes #4785

Signed-off-by: Chelsea Finnie [email protected]

Pull Request Checklist

• I read the contributing guide
• UI change has been tested on both light and dark themes, in portrait and landscape orientations and on iPhone and iPad simulators
• Pull request is based on the develop branch
• Pull request contains a changelog file in ./changelog.d
• Pull request includes screenshots or videos of UI changes
• Pull request includes a sign off

[SBiOSoftWhare]

Hi @pengufrost, thanks for your contribution. Your fix works in the case when there is no SSO identity provider defined. If you choose a SSO provider on Matrix.org like GitHub for example it will not work. We just need a small addition to the SSOAuthenticationService.swift code here to handle identity providers. Just adding a / when needed by doing ssoRedirectPath.append("/\(identityProvider)") instead of ssoRedirectPath.append(identityProvider) will make the fix working for all cases :)

[pengufrost]

Hi @pengufrost, thanks for your contribution. Your fix works in the case when there is no SSO identity provider defined. If you choose a SSO provider on Matrix.org like GitHub for example it will not work. We just need a small addition to the SSOAuthenticationService.swift code here to handle identity providers. Just adding a / when needed by doing ssoRedirectPath.append("/\(identityProvider)") instead of ssoRedirectPath.append(identityProvider) will make the fix working for all cases :)

Cheers, added the change to the branch. Tested that this works with our SSO service.

[SBiOSoftWhare]

Cheers, added the change to the branch. Tested that this works with our SSO service.

Perfect! Thank you very much for this update.