Support pagination in the Space Summary API #4994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
📱 Scan the QR code below to install the build for this PR. If you can't scan the QR code you can install the build via this link: https://i.diawi.com/xZ8Qec |
|
From the image, it looks like the loading indicator is a circle?
On iOS, loading is normally indicated by the traditional activity indicator. Are we able to use the same iconography inline? |
- Move back to default iOS activity indicator
- Revert test tweaks
SBiOSoftWhare
approved these changes
Oct 26, 2021
| import UIKit | ||
| import Reusable | ||
|
|
||
| class SpaceChildLoadingViewCell: UITableViewCell, NibReusable, Themable { |
There was a problem hiding this comment.
Is this cell will be reuse for other screens? If yes maybe we can use a common name like PaginationLoadingViewCell
- Update after review
SBiOSoftWhare
approved these changes
Oct 27, 2021
niquewoodhouse
approved these changes
Oct 28, 2021
gileluard
deleted the
gil/4893_support_pagination_in_the_space_summary_api
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #4893
Testable link: https://i.diawi.com/aEaPQD