Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle showMediaSizeSelection in the share extension. #5059

Merged
merged 4 commits into from
Oct 29, 2021
Merged

Handle showMediaSizeSelection in the share extension. #5059

merged 4 commits into from
Oct 29, 2021

Conversation

pixlwave
Copy link
Member

The changes this PR makes are:

  • Don't show a media size selection prompt when the user has disabled it
  • When sending photos as actual size, send the original data rather than rotating it and recompressing it to avoid exceeding the memory limit. This behaviour now matches Web which sends the original file unmodified.
  • When sending videos to an encrypted room, never show a media size selection prompt and always send a low quality 320p video like the app used to. This includes a prompt to alert the user of the fact:

View recent photos 2

stefanceriu
stefanceriu approved these changes Oct 29, 2021
View reviewed changes
Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@github-actions
Copy link

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

QR code

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/Eo3y2D

@pixlwave pixlwave merged commit d0555b5 into develop Oct 29, 2021
@pixlwave pixlwave deleted the doug/4815_share_extension_prompt branch October 29, 2021 12:03
@pixlwave pixlwave linked an issue Oct 29, 2021 that may be closed by this pull request
Share extension asks you to compress videos/photos even if setting is disabled #4815
Closed
@pixlwave pixlwave mentioned this pull request Oct 29, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niquewoodhouse niquewoodhouse niquewoodhouse approved these changes

@stefanceriu stefanceriu stefanceriu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Share extension asks you to compress videos/photos even if setting is disabled
3 participants
@pixlwave @stefanceriu @niquewoodhouse