Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add clientPermalinkBaseUrl and set in matrix-sdk options. #5060

Merged
merged 3 commits into from
Nov 4, 2021
Merged

Add clientPermalinkBaseUrl and set in matrix-sdk options. #5060

merged 3 commits into from
Nov 4, 2021

Conversation

langleyd
Copy link
Member

@langleyd langleyd commented Oct 29, 2021 •
edited
Loading

@langleyd langleyd mentioned this pull request Oct 29, 2021
Merged
@giomfo giomfo self-assigned this Nov 4, 2021
giomfo
giomfo reviewed Nov 4, 2021
View reviewed changes
Copy link
Member

@giomfo giomfo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM, I'm currently testing before approving this change

I share my comment here, and a question:
don't you have to add a changelog file? or is it handled by the one added in the PR at the sdk level?

Config/BuildSettings.swift Show resolved Hide resolved
giomfo
giomfo approved these changes Nov 4, 2021
View reviewed changes
Copy link
Member

@giomfo giomfo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All tests were ok
I approved and let you consider my previous comment, and the question about changelog

@github-actions
Copy link

github-actions bot commented Nov 4, 2021 •
edited
Loading

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

QR code

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/xMv8pC

@langleyd langleyd merged commit e236934 into develop Nov 4, 2021
@langleyd langleyd deleted the langleyd/4981_custom_baseurl_permalinks branch November 4, 2021 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giomfo giomfo giomfo approved these changes

@SBiOSoftWhare SBiOSoftWhare SBiOSoftWhare approved these changes

Assignees

@giomfo giomfo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a client base url config to customize permalinks
3 participants
@langleyd @SBiOSoftWhare @giomfo