Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix retain cycles #5061

Merged
merged 15 commits into from
Oct 29, 2021
Merged

Fix retain cycles #5061

merged 15 commits into from
Oct 29, 2021

Conversation

SBiOSoftWhare
Copy link
Contributor

Fix retain cycles in:

  • GroupsViewController
  • SegmentedViewController
  • ContactDetailsViewController
  • SettingsViewController
  • ContactsTableViewController: Prevent retain cycles.

Part of #5058

@github-actions
Copy link

github-actions bot commented Oct 29, 2021 •
edited
Loading

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

QR code

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/iJA8Mw

@SBiOSoftWhare SBiOSoftWhare merged commit 88d46cd into develop Oct 29, 2021
@SBiOSoftWhare SBiOSoftWhare deleted the steve/5058_fix_retain_cycles branch October 29, 2021 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pixlwave pixlwave pixlwave approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SBiOSoftWhare @pixlwave