Fix for images sometimes being sent unencrypted in an encrypted room. #5567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
📱 Scan the QR code below to install the build for this PR. If you can't scan the QR code you can install the build via this link: https://i.diawi.com/Q4ovJW |
pixlwave
force-pushed
the
doug/5564_unencrypted_images
branch
from
95769f6 to
7d2067e
Compare
pixlwave
force-pushed
the
doug/5564_unencrypted_images
branch
from
7d2067e to
cb57f5e
Compare
The logic around when to send a typing notification also includes logic around when to exchange encryption keys. handleTypingNotification renamed to handleTypingState for clarity.
|
The new commit refines the no-op in a thread view to only apply to the sending of the notification. This way |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following on from matrix-org/matrix-ios-sdk#1358 it is possible in 1.8.0 TF for the query to a room's encryption algorithm to occur before that algorithm has been stored in the realm when sending an image. When sending a text message the algorithm gets stored when
shareEncryptionKeysis called before a typing notification is created.This PR mimics the same behaviour by calling
shareEncryptionKeyswhen the composer's action menu is displayed as none of those events send typing notifications. That said, I think some deeper thought needs to go into the timing of all of this if we are going to rely on using the realm for encryption status.