Fix HTML render for links containing Markdown formatting #5587
Conversation
|
📱 Scan the QR code below to install the build for this PR. If you can't scan the QR code you can install the build via this link: https://i.diawi.com/4DkfdJ |
Riot/Modules/MatrixKit/Utils/EventFormatter/MarkdownToHTMLRenderer.swift
Outdated
Show resolved
Hide resolved
| /// Repairs links that were broken down by markdown formatting. | ||
| /// Should be used on the first node of libcmark's AST | ||
| /// (e.g. the object returned by DownASTRenderer.stringToAST). | ||
| func repairLinks() { |
There was a problem hiding this comment.
Not going to pretend I understand everything this does but I trust that we'll find out pretty fast if it breaks anything 😅
There was a problem hiding this comment.
Yeah, I already added a nice coverage with unit tests. But if someone ever finds a string that manages to break it, I suppose we will just have to fix it and extend our unit tests with it :)
If you have suggestions of weird strings that I could add to unit tests, feel free
| cmark_node_set_literal(node.pointee.first_child, "") | ||
| let newIterator = cmark_iter_new(node) | ||
| _ = cmark_iter_next(newIterator) | ||
| cmark_node_unlink(node) |
There was a problem hiding this comment.
these unlink actually don't free mem (at least not immediately), I will update for that,
I'll take a look if I can as well make sure that created node that I link manually to the AST are properly freed (hopefully they are, cause freeing manually afterwards would look terrible)
aringenbach
deleted the
aringenbach/5355_fix_links_with_markdown_formatting_symbols
branch
Fixes #5355
This is partly adapted from similar issue in element-web (details available on linked issue description).