Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure the login button is always visible #5892

Merged
merged 1 commit into from
Mar 23, 2022
Merged

Conversation

Anderas
Copy link
Contributor

@Anderas Anderas commented Mar 22, 2022

Fixes #5875

Ensure that login / register button is always visible by separating the button and "forgot password" onto two separate lines.

Before After
159138005-7b7d6925-6042-4f69-a411-a0413e81f522 Simulator Screen Shot - iPhone 13 - 2022-03-22 at 11 29 30

The constraints in the xib file are quite messy so I just embedded the main 3 components (submit, skip, forgotten button) into stack views and replicating the existing distances. Below are a number of different views to make sure there are no collisions

Login Register With Skip Double length
Simulator Screen Shot - iPhone 13 - 2022-03-22 at 11 29 30 Simulator Screen Shot - iPhone 13 - 2022-03-22 at 11 29 33 Simulator Screen Shot - iPhone 13 - 2022-03-22 at 11 31 26 Simulator Screen Shot - iPhone 13 - 2022-03-22 at 11 32 07
iPad login iPad register Small login Small register
Simulator Screen Shot - iPad Pro (12 9-inch) (5th generation) - 2022-03-22 at 11 36 47 Simulator Screen Shot - iPad Pro (12 9-inch) (5th generation) - 2022-03-22 at 11 36 57 Simulator Screen Shot - iPod touch (7th generation) - 2022-03-22 at 11 42 10 Simulator Screen Shot - iPod touch (7th generation) - 2022-03-22 at 11 42 12

@Anderas Anderas requested review from a team and ismailgulek and removed request for a team March 22, 2022 11:51
@github-actions
Copy link

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

QR code

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/tY8P8w

@Anderas Anderas requested review from a team and stefanceriu and removed request for ismailgulek and a team March 23, 2022 08:33
Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@Anderas Anderas merged commit db26880 into develop Mar 23, 2022
@Anderas Anderas deleted the andy/5875_login_button branch March 23, 2022 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Button "Login" not really visible with german language
2 participants