Fix retain cycle in MXKRoomDataSource #5923
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first part of a fix for a triple-leak involving
MXKRoomDataSource
,MXRoomEventTimeline
andMXEventListener
. The second part can be found in matrix-org/matrix-ios-sdk#1424.The concrete issue here is that
MXKRoomDataSource
stores an event listener in a strong property but capturesself
in the listener'sonEvent
block.I haven't found concrete steps to reproduce the leak (and the memory graph debugger is also not 100% reliable) but the cycle frequently shows after having entered, left and posted in rooms a few times.
Relates to: #5058
Pull Request Checklist