Location sharing: Live location sharing viewer screen #5994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…troller to share a location.
# Conflicts: # Riot/Assets/en.lproj/Vector.strings # Riot/Generated/Strings.swift # RiotSwiftUI/Modules/Room/LocationSharing/Coordinator/ShareLocationActivityController.swift # RiotSwiftUI/Modules/Room/LocationSharing/MapViewErrorAlertInfoBuilder.swift
SBiOSoftWhare
requested review from
a team and
MaximeEvrard42
and removed request for
a team
|
📱 Scan the QR code below to install the build for this PR. If you can't scan the QR code you can install the build via this link: https://i.diawi.com/pRSPnb |
MaximeEvrard42
approved these changes
Apr 22, 2022
|
|
||
| let alertInfo: AlertInfo<LocationSharingAlertType>? | ||
|
|
||
| switch error { | ||
| case .failedLoadingMap: | ||
| alertInfo = AlertInfo(id: .mapLoadingError, | ||
| title: VectorL10n.locationSharingLoadingMapErrorTitle(AppInfo.current.displayName), | ||
| primaryButton: (VectorL10n.ok, dimissalCallback)) | ||
| primaryButton: (VectorL10n.ok, primaryButtonCompletion)) |
There was a problem hiding this comment.
I think "dismissalCallBack" is more generic as this action is used whenever it's a primaryButton or not
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#5723