Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix room preview crash #6085

Merged
merged 2 commits into from
Apr 29, 2022
Merged

Fix room preview crash #6085

merged 2 commits into from
Apr 29, 2022

Conversation

ismailgulek
Copy link
Contributor

@ismailgulek ismailgulek commented Apr 28, 2022 •
edited
Loading

Fixes #5883

@ismailgulek ismailgulek requested review from a team, MaximeEvrard42 and aringenbach and removed request for a team April 28, 2022 13:34
@github-actions
Copy link

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

QR code

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/9v9eSo

MaximeEvrard42
MaximeEvrard42 suggested changes Apr 29, 2022
View reviewed changes
Copy link
Contributor

@MaximeEvrard42 MaximeEvrard42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think your fix was not enought, when I try to access to room throught direct link like in the issue, I got a crash too.

Capture d’écran 2022-04-29 à 10 51 19

aringenbach
aringenbach approved these changes Apr 29, 2022
View reviewed changes
Copy link
Contributor

@aringenbach aringenbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aringenbach
Copy link
Contributor

I think your fix was not enought, when I try to access to room throught direct link like in the issue, I got a crash too.

Maybe some residual thing from XCode build ? Cause this fixed the issue for me (I cleaned in between)

MaximeEvrard42
MaximeEvrard42 approved these changes Apr 29, 2022
View reviewed changes
Copy link
Contributor

@MaximeEvrard42 MaximeEvrard42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was a false flag, I tested again and it's ok

@ismailgulek ismailgulek merged commit bc8a397 into develop Apr 29, 2022
@ismailgulek ismailgulek deleted the ismail/5883_room_preview_crash branch April 29, 2022 10:39
@manuroe manuroe mentioned this pull request May 4, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aringenbach aringenbach aringenbach approved these changes

@MaximeEvrard42 MaximeEvrard42 MaximeEvrard42 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

App crashes when trying to join a room by its address
3 participants
@ismailgulek @aringenbach @MaximeEvrard42