Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent crash when searching #6116

Merged
merged 1 commit into from
May 3, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions Riot/Modules/Common/Recents/RecentsViewController.m
Original file line number Diff line number Diff line change
Expand Up @@ -1088,8 +1088,12 @@ - (void)dataSource:(MXKDataSource *)dataSource didCellChange:(id)changes
}
else
{
MXLogDebug(@"[RecentsViewController]: Reloading table view section %ld", indexPath.section);
[self.recentsTableView reloadSections:[NSIndexSet indexSetWithIndex:indexPath.section] withRowAnimation:UITableViewRowAnimationNone];
// Ideally we would call tableView.reloadSections, but this can lead to crashes if multiple sections need such an update and they
// vertically depend on each other. It is unclear whether this is due to further issues in the data model (e.g. data race)
// or some undocumented table view behavior. To avoid this we reload the entire table view, even if this means reloading
// multiple times for several section updates.
MXLogDebug(@"[RecentsViewController]: Reloading the entire table view due to updates in section %ld", indexPath.section);
[self refreshRecentsTable];
}
}
else if (!changes)
Expand Down
1 change: 1 addition & 0 deletions changelog.d/6115.bugfix
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Search: Prevent crash when searching