Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FTUE: Password recovery #6235

Merged
merged 11 commits into from
Jun 6, 2022
Merged

FTUE: Password recovery #6235

merged 11 commits into from
Jun 6, 2022

Conversation

ismailgulek
Copy link
Contributor

Fixes #5655

@ismailgulek ismailgulek requested a review from pixlwave June 1, 2022 16:01
@github-actions
Copy link

github-actions bot commented Jun 1, 2022 •
edited
Loading

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

QR code

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/tsD4V6

pixlwave
pixlwave reviewed Jun 1, 2022
View reviewed changes
Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Ismail, haven't tested it but looks great! There are a couple of asks in the comments, otherwise just minor points. 👍

RiotSwiftUI/Modules/Authentication/Login/Coordinator/AuthenticationLoginCoordinator.swift Show resolved Hide resolved
RiotSwiftUI/Modules/Authentication/Login/Coordinator/AuthenticationLoginCoordinator.swift Outdated Show resolved Hide resolved
...ules/Authentication/ForgotPassword/Coordinator/AuthenticationForgotPasswordCoordinator.swift Outdated Show resolved Hide resolved
RiotSwiftUI/Modules/Authentication/ChoosePassword/View/AuthenticationChoosePasswordScreen.swift Outdated Show resolved Hide resolved
RiotSwiftUI/Modules/Authentication/ChoosePassword/View/AuthenticationChoosePasswordScreen.swift Outdated Show resolved Hide resolved
RiotSwiftUI/Modules/Authentication/ChoosePassword/View/AuthenticationChoosePasswordForm.swift Outdated Show resolved Hide resolved
RiotSwiftUI/Modules/Authentication/ChoosePassword/View/AuthenticationChoosePasswordForm.swift Outdated Show resolved Hide resolved
...ules/Authentication/ChoosePassword/Coordinator/AuthenticationChoosePasswordCoordinator.swift Outdated Show resolved Hide resolved
RiotSwiftUI/Modules/Authentication/ForgotPassword/View/AuthenticationForgotPasswordScreen.swift Outdated Show resolved Hide resolved
@ismailgulek
Copy link
Contributor Author

ismailgulek commented Jun 1, 2022 •
edited
Loading

Flow:

password_reset.mov

@ismailgulek ismailgulek requested a review from pixlwave June 1, 2022 21:30
pixlwave
pixlwave approved these changes Jun 6, 2022
View reviewed changes
Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Ismail, looks great!

RiotSwiftUI/Modules/Onboarding/Common/OnboardingBreakerScreenBackground.swift Show resolved Hide resolved
RiotSwiftUI/Modules/Authentication/ChoosePassword/View/AuthenticationChoosePasswordScreen.swift Outdated Show resolved Hide resolved
RiotSwiftUI/Modules/Authentication/ForgotPassword/View/AuthenticationForgotPasswordScreen.swift Outdated Show resolved Hide resolved
RiotSwiftUI/Modules/Authentication/ForgotPassword/View/AuthenticationForgotPasswordScreen.swift Outdated Show resolved Hide resolved
@ismailgulek
Copy link
Contributor Author

Thanks @pixlwave for further comments, i've updated.

@ismailgulek ismailgulek merged commit 9ed783f into develop Jun 6, 2022
@ismailgulek ismailgulek deleted the ismail/5655_reset_password branch June 6, 2022 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pixlwave pixlwave pixlwave approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mobile FTUE: Password recovery (iOS)
2 participants
@ismailgulek @pixlwave