Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use latest user data for mention pills #6309

Merged
merged 3 commits into from
Jun 17, 2022
Merged

Use latest user data for mention pills #6309

merged 3 commits into from
Jun 17, 2022

Conversation

aringenbach
Copy link
Contributor

Fixes #6302

@github-actions
Copy link

github-actions bot commented Jun 16, 2022 •
edited
Loading

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

QR code

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/5tstXN

@aringenbach aringenbach requested review from a team, stefanceriu and pixlwave and removed request for a team June 17, 2022 08:19
pixlwave
pixlwave approved these changes Jun 17, 2022
View reviewed changes
Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Surprising how many calls there were that needed updating 😅

stefanceriu
stefanceriu approved these changes Jun 17, 2022
View reviewed changes
Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me too 👍

@aringenbach aringenbach merged commit 5aba712 into develop Jun 17, 2022
@aringenbach aringenbach deleted the aringenbach/6302_use_latest_data_for_pills branch June 17, 2022 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pixlwave pixlwave pixlwave approved these changes

@stefanceriu stefanceriu stefanceriu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mention pills should display latest avatar and displayname
3 participants
@aringenbach @stefanceriu @pixlwave