Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pasteboard banner when editing text. #6336

Merged
merged 1 commit into from
Jun 23, 2022

Conversation

pixlwave
Copy link
Member

Inspecting the items on the pasteboard to determine whether pasting is possible causes the banner to appear. This PR updates the check to inspect the types on the pasteboard instead. I didn't seem to see this when copying an image from Safari (presumably as there is also text on the pasteboard in the form of a URL so it doesn't go up the responder chain to check), but could reproduce it when copying an image from the photos app.

Fixes #5324

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@github-actions
Copy link

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

QR code

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/28QiWS

Copy link
Contributor

@ismailgulek ismailgulek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@codecov-commenter
Copy link

Codecov Report

Merging #6336 (a2c1731) into develop (8927bff) will increase coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff            @@
##           develop    #6336    +/-   ##
=========================================
  Coverage     6.17%    6.18%            
=========================================
  Files         1440     1440            
  Lines       155408   155102   -306     
  Branches     62521    62363   -158     
=========================================
- Hits          9592     9587     -5     
+ Misses      145413   145112   -301     
  Partials       403      403            
Impacted Files Coverage Δ
...t/Views/RoomInputToolbar/MXKRoomInputToolbarView.m 0.00% <0.00%> (ø)
.../Modules/Spaces/SpaceList/SpaceListViewModel.swift 37.45% <0.00%> (-0.50%) ⬇️
Riot/Modules/Application/AppCoordinator.swift 53.26% <0.00%> (-0.24%) ⬇️
Riot/Modules/Application/LegacyAppDelegate.m 13.55% <0.00%> (-0.14%) ⬇️
Riot/Categories/Publisher+Riot.swift 66.66% <0.00%> (ø)
Riot/Modules/Room/RoomCoordinator.swift 0.00% <0.00%> (ø)
Riot/Modules/Settings/SettingsViewController.m 0.00% <0.00%> (ø)
RiotSwiftUI/Modules/Common/Theme/ThemeKey.swift 62.50% <0.00%> (ø)
RiotSwiftUI/Modules/Common/Util/SearchBar.swift 0.00% <0.00%> (ø)
RiotSwiftUI/Modules/Common/Mock/ScreenList.swift 0.00% <0.00%> (ø)
... and 213 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8927bff...a2c1731. Read the comment docs.

Copy link
Contributor

@gileluard gileluard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@pixlwave pixlwave merged commit b705db0 into develop Jun 23, 2022
@pixlwave pixlwave deleted the doug/5324-fix-pasteboard-banner branch June 23, 2022 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Element copied from X" popup when selecting text
4 participants