Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "Mark as read" #6346

Merged
merged 2 commits into from
Jun 28, 2022
Merged

Add "Mark as read" #6346

merged 2 commits into from
Jun 28, 2022

Conversation

gileluard
Copy link
Contributor

resolves #6278

Simulator Screen Shot - iPhone 12 Pro - 2022-06-13 at 14 49 25

@gileluard
Add "Mark as read"
04a553d 
- First implementation
@gileluard gileluard requested review from a team, ismailgulek and aringenbach and removed request for a team June 27, 2022 13:17
@github-actions
Copy link

github-actions bot commented Jun 27, 2022 •
edited
Loading

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

QR code

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/Y83Spr

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (develop@27178d5). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             develop    #6346   +/-   ##
==========================================
  Coverage           ?    6.19%           
==========================================
  Files              ?     1440           
  Lines              ?   155125           
  Branches           ?    62371           
==========================================
  Hits               ?     9611           
  Misses             ?   145109           
  Partials           ?      405

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27178d5...04a553d. Read the comment docs.

aringenbach
aringenbach approved these changes Jun 27, 2022
View reviewed changes
Copy link
Contributor

@aringenbach aringenbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

ismailgulek
ismailgulek reviewed Jun 27, 2022
View reviewed changes
changelog.d/6278.feature Outdated
@@ -0,0 +1 @@
Add "Mark as read"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could improve this changelog a bit more, otherwise LGTM!

@gileluard
Add "Mark as read"
785f5c1 
- Update after review
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@gileluard gileluard merged commit d8c77a6 into develop Jun 28, 2022
@gileluard gileluard deleted the gil/6278-Add_Mark_as_read branch June 28, 2022 08:44
stefanceriu pushed a commit that referenced this pull request Jun 28, 2022
@gileluard @stefanceriu
Add "Mark as read" (#6346)
541dc8f 
* Add "Mark as read"

- done
@noantiq noantiq mentioned this pull request Jun 28, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aringenbach aringenbach aringenbach approved these changes

@ismailgulek ismailgulek ismailgulek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add "Mark as read"
4 participants
@gileluard @codecov-commenter @ismailgulek @aringenbach