FTUE tweaks #6450
FTUE tweaks #6450
Conversation
- Allow login using a phone number. - Update the server when entering a full MXID during registration. - Reset the authentication service back to matrix.org after onboarding completes. - Disable zoom on ReCaptcha to fix responsiveness issue. - Tidy up unused methods.
pixlwave
requested review from
a team and
SBiOSoftWhare
and removed request for
a team
|
Kudos, SonarCloud Quality Gate passed!
|
| @@ -195,8 +195,8 @@ final class AuthenticationLoginCoordinator: Coordinator, Presentable { | |||
|
|
|||
| @MainActor private func parseUsername(_ username: String) { | |||
| guard MXTools.isMatrixUserIdentifier(username) else { return } | |||
| let domain = username.split(separator: ":")[1] | |||
| let homeserverAddress = HomeserverAddress.sanitized(String(domain)) | |||
| let domain = username.components(separatedBy: ":")[1] | |||
There was a problem hiding this comment.
Is there a risk to get username without : symbol here? if yes it can crash.
There was a problem hiding this comment.
There shouldn't be as the guard MXTools.isMatrixUserIdentifier(username) else { return } should prevent us from reaching this code if it isn't a valid MXID.
| @@ -59,10 +59,20 @@ class AuthenticationRegistrationViewModel: AuthenticationRegistrationViewModelTy | |||
| } | |||
| } | |||
|
|
|||
| @MainActor func update(isLoading: Bool) { | |||
| guard state.isLoading != isLoading else { return } | |||
There was a problem hiding this comment.
Is there existing way like property wrappers to have this behavior?
There was a problem hiding this comment.
Nothing built in as far as I'm aware but wouldn't be difficult to make one. Seems a bit out of scope to start doing that in this PR though.
|
📱 Scan the QR code below to install the build for this PR. If you can't scan the QR code you can install the build via this link: https://i.diawi.com/MS2iXy |
There is one more string to update, otherwise this is it (pending user testing).
Closes #6428. Closes #6429. Closes #6430.
Input of full MXID during Registration
