Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

App Layout: Cancel and Back on Spaces Bottom Sheet #6582

Merged
merged 2 commits into from
Aug 18, 2022
Merged

App Layout: Cancel and Back on Spaces Bottom Sheet #6582

merged 2 commits into from
Aug 18, 2022

Conversation

gileluard
Copy link
Contributor

resolves #6572

ezgif-1-86036dcbfb

@gileluard gileluard requested review from a team and stefanceriu and removed request for a team August 17, 2022 15:24
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@github-actions
Copy link

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

QR code

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/VowG4B

stefanceriu
stefanceriu approved these changes Aug 18, 2022
View reviewed changes
Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@gileluard gileluard merged commit 2643298 into develop Aug 18, 2022
@gileluard gileluard deleted the gil/6572-Cancel_and_Back_on_Spaces_Bottom_Sheet branch August 18, 2022 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefanceriu stefanceriu stefanceriu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

App Layout: Cancel and Back on Spaces Bottom Sheet
2 participants
@gileluard @stefanceriu