Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing empty states in new app layout #6598

Merged
merged 2 commits into from
Aug 22, 2022

Conversation

gileluard
Copy link
Contributor

resolves #6514

Empty states for empty all chats (home space), empty space list, empty all chats (any space)
ezgif-5-e6afb51e87

Empty state for all chats section
ezgif-5-63983b8ea2

…tom sheet

- make breadcrumbs visible accordingly with the all chats layout options
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@github-actions
Copy link

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

QR code

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/VpmiPT

@codecov-commenter
Copy link

Codecov Report

Merging #6598 (1bd8e9a) into develop (a0a6f20) will increase coverage by 0.01%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop    #6598      +/-   ##
===========================================
+ Coverage     6.26%    6.27%   +0.01%     
===========================================
  Files         1456     1457       +1     
  Lines       153974   154111     +137     
  Branches     61899    61939      +40     
===========================================
+ Hits          9646     9670      +24     
- Misses      143922   144033     +111     
- Partials       406      408       +2     
Impacted Files Coverage Δ
Riot/Generated/Images.swift 54.76% <ø> (ø)
Riot/Generated/Strings.swift 2.87% <0.00%> (-0.01%) ⬇️
...les/Common/Recents/DataSources/RecentsDataSource.m 6.86% <0.00%> (-0.05%) ⬇️
...Recents/Service/MatrixSDK/RecentsListService.swift 12.03% <0.00%> (ø)
...ecents/Views/RecentEmptySectionTableViewCell.swift 0.00% <0.00%> (ø)
...Modules/Home/AllChats/AllChatsViewController.swift 0.00% <0.00%> (ø)
...t/SpaceSelector/MockSpaceSelectorScreenState.swift 0.00% <0.00%> (ø)
...ector/Service/MatrixSDK/SpaceSelectorService.swift 0.00% <0.00%> (ø)
...BottomSheet/SpaceSelector/View/SpaceSelector.swift 0.00% <0.00%> (ø)
...ing/SplashScreen/View/OnboardingSplashScreen.swift 58.66% <0.00%> (+4.00%) ⬆️
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@gileluard gileluard marked this pull request as ready for review August 22, 2022 11:04
@gileluard gileluard requested review from a team and aringenbach and removed request for a team August 22, 2022 11:04
Copy link
Contributor

@aringenbach aringenbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gileluard gileluard merged commit 1d0db6e into develop Aug 22, 2022
@gileluard gileluard deleted the gil/6514-Missing_empty_states_in_new_app_layout branch August 22, 2022 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing empty states in new app layout room list
3 participants