Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App Layout: UI tweaks for Tabs #6606

Merged
merged 1 commit into from
Aug 22, 2022

Conversation

gileluard
Copy link
Contributor

resolves #6605

ezgif-4-23b910ac03

@gileluard gileluard requested review from a team, pixlwave and stefanceriu and removed request for a team and pixlwave August 22, 2022 14:26
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 😎

@github-actions
Copy link

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

QR code

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/gqatFz

@codecov-commenter
Copy link

Codecov Report

Merging #6606 (3b2a85f) into develop (a0a6f20) will increase coverage by 0.00%.
The diff coverage is 0.00%.

@@           Coverage Diff            @@
##           develop    #6606   +/-   ##
========================================
  Coverage     6.26%    6.27%           
========================================
  Files         1456     1456           
  Lines       153974   153988   +14     
  Branches     61899    61902    +3     
========================================
+ Hits          9646     9657   +11     
- Misses      143922   143925    +3     
  Partials       406      406           
Impacted Files Coverage Δ
.../SectionHeaders/AllChatsFilterOptionListView.swift 0.00% <0.00%> (ø)
...ot/Modules/Common/SectionHeaders/TabListView.swift 0.00% <0.00%> (ø)
Config/CommonConfiguration.swift 85.71% <0.00%> (-5.20%) ⬇️
Riot/Managers/Call/CallPresenter.swift 1.08% <0.00%> (-5.14%) ⬇️
...rs/EncryptionKeyManager/EncryptionKeyManager.swift 35.41% <0.00%> (-4.17%) ⬇️
Riot/Modules/Application/LegacyAppDelegate.m 13.59% <0.00%> (-0.35%) ⬇️
...xKit/Controllers/MXKAuthenticationViewController.m 19.01% <0.00%> (ø)
...ing/SplashScreen/View/OnboardingSplashScreen.swift 58.66% <0.00%> (+4.00%) ⬆️
Riot/Categories/String.swift 33.33% <0.00%> (+11.11%) ⬆️
...Modules/Common/ViewModel/StateStoreViewModel.swift 50.00% <0.00%> (+19.44%) ⬆️
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@gileluard gileluard merged commit e793a4a into develop Aug 22, 2022
@gileluard gileluard deleted the gil/6605-App_Layout-UI_tweaks_for_Tabs branch August 22, 2022 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

App Layout: UI tweaks for Tabs
3 participants