Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App Layout: Activate feature #6617

Merged
merged 1 commit into from
Aug 24, 2022

Conversation

gileluard
Copy link
Contributor

resolves #6616

@gileluard gileluard requested a review from stefanceriu August 23, 2022 20:06
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov-commenter
Copy link

Codecov Report

Merging #6617 (2f9e214) into develop (de291a5) will decrease coverage by 0.32%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #6617      +/-   ##
===========================================
- Coverage     6.24%    5.92%   -0.33%     
===========================================
  Files         1473     1473              
  Lines       154802   154805       +3     
  Branches     62208    62209       +1     
===========================================
- Hits          9669     9173     -496     
- Misses      144725   145221     +496     
- Partials       408      411       +3     
Impacted Files Coverage Δ
Config/BuildSettings.swift 43.07% <ø> (ø)
...ces/SpaceList/SpaceListCoordinatorParameters.swift 0.00% <0.00%> (-100.00%) ⬇️
Riot/Modules/TabBar/MainTitleView.swift 0.00% <0.00%> (-85.19%) ⬇️
...les/Spaces/SpaceList/SpaceListViewController.swift 0.00% <0.00%> (-68.85%) ⬇️
...ActivityIndicator/ActivityIndicatorPresenter.swift 0.00% <0.00%> (-51.73%) ⬇️
Riot/Generated/Storyboards.swift 0.00% <0.00%> (-45.46%) ⬇️
Riot/Modules/SideMenu/SideMenuViewController.swift 0.00% <0.00%> (-44.21%) ⬇️
Riot/Modules/SideMenu/SideMenuViewModel.swift 0.00% <0.00%> (-44.19%) ⬇️
...odules/Spaces/SpaceList/SpaceListCoordinator.swift 0.00% <0.00%> (-41.67%) ⬇️
...ctivityIndicator/UIKit/ActivityIndicatorView.swift 0.00% <0.00%> (-37.84%) ⬇️
... and 40 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions
Copy link

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

QR code

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/xihAip

Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 it! 🚀

@stefanceriu stefanceriu merged commit 2c7820b into develop Aug 24, 2022
@stefanceriu stefanceriu deleted the gil/6616-App_Layout-Activate_feature branch August 24, 2022 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

App Layout: Activate feature
3 participants