Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated empty states as per latest design update #6678

Merged
merged 1 commit into from
Sep 6, 2022
Merged

Updated empty states as per latest design update #6678

merged 1 commit into from
Sep 6, 2022

Conversation

gileluard
Copy link
Contributor

@gileluard gileluard commented Sep 5, 2022 •
edited
Loading

Resolves #6674

state Light Mode Dark Mode
No rooms (All Chats) Simulator Screen Shot - iPhone 12 Pro - 2022-09-05 at 14 01 04 Simulator Screen Shot - iPhone 12 Pro - 2022-09-05 at 14 02 23
No rooms (in space) and no Recents Simulator Screen Shot - iPhone 12 Pro - 2022-09-05 at 14 08 54 Simulator Screen Shot - iPhone 12 Pro - 2022-09-05 at 14 09 59
No rooms (in space) with Recents Simulator Screen Shot - iPhone 12 Pro - 2022-09-05 at 15 13 21 Simulator Screen Shot - iPhone 12 Pro - 2022-09-05 at 15 13 54
Empty Unread section Simulator Screen Shot - iPhone 12 Pro - 2022-09-05 at 15 47 47 Simulator Screen Shot - iPhone 12 Pro - 2022-09-05 at 15 47 11

@gileluard gileluard requested review from a team and aringenbach and removed request for a team September 5, 2022 14:12
@gileluard
Copy link
Contributor Author

@amshakal if you have any comment UI wise, please let me know.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 5, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@github-actions
Copy link

github-actions bot commented Sep 5, 2022

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

QR code

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/weNtJq

ismailgulek
ismailgulek approved these changes Sep 6, 2022
View reviewed changes
Copy link
Contributor

@ismailgulek ismailgulek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gileluard gileluard merged commit d65143a into develop Sep 6, 2022
@gileluard gileluard deleted the gil/6674-Update_empty_states_as_per_latest_design_update branch September 6, 2022 07:01
aringenbach
aringenbach approved these changes Sep 6, 2022
View reviewed changes
Copy link
Contributor

@aringenbach aringenbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aringenbach aringenbach aringenbach approved these changes

@ismailgulek ismailgulek ismailgulek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update empty states as per latest design update
3 participants
@gileluard @ismailgulek @aringenbach