Fix login crash on Xcode 14 builds #6728

Johennes · 2022-09-15T19:22:52Z

To be honest, I'm not sure if this is a Swift bug or not but the additional @MainActor appears to force the awaited call onto the main thread which prevents the assertion.

Pull Request Checklist

I read the contributing guide
UI change has been tested on both light and dark themes, in portrait and landscape orientations and on iPhone and iPad simulators
Accessibility has been taken into account.

Pull request is based on the develop branch

Pull request contains a changelog file in ./changelog.d
You've made a self review of your PR
Pull request includes screenshots or videos of UI changes
Pull request includes a sign off

Fixes #6722

github-actions · 2022-09-15T19:50:55Z

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/fsALxs

codecov · 2022-09-15T19:59:22Z

Codecov Report

Base: 9.92% // Head: 9.96% // Increases project coverage by +0.03% 🎉

Coverage data is based on head (9a1c12f) compared to base (75bd23d).
Patch coverage: 57.14% of modified lines in pull request are covered.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #6728      +/-   ##
===========================================
+ Coverage     9.92%    9.96%   +0.03%     
===========================================
  Files         1484     1484              
  Lines       150486   150506      +20     
  Branches     60742    60752      +10     
===========================================
+ Hits         14934    14992      +58     
+ Misses      135006   134960      -46     
- Partials       546      554       +8

Impacted Files	Coverage Δ
...tion/Common/Service/MatrixSDK/SessionCreator.swift	`67.74% <ø> (ø)`
...ication/Common/Service/MatrixSDK/LoginWizard.swift	`35.93% <50.00%> (ø)`
.../Common/Service/MatrixSDK/RegistrationWizard.swift	`36.31% <100.00%> (ø)`
...iot/Modules/Analytics/SentryMonitoringClient.swift	`0.00% <0.00%> (ø)`
...Recents/Service/MatrixSDK/RecentsListService.swift	`12.32% <0.00%> (+0.15%)`	⬆️
Riot/Modules/Application/LegacyAppDelegate.m	`13.40% <0.00%> (+0.60%)`	⬆️
...anagers/PushNotification/PushNotificationService.m	`11.45% <0.00%> (+1.04%)`	⬆️
...ing/SplashScreen/View/OnboardingSplashScreen.swift	`58.66% <0.00%> (+4.00%)`	⬆️
Riot/Modules/Application/AppDelegate.swift	`55.38% <0.00%> (+4.61%)`	⬆️
...calAuthentication/LocalAuthenticationService.swift	`54.54% <0.00%> (+27.27%)`	⬆️
... and 1 more