Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix code block background colour #6779

Merged

Conversation

aringenbach
Copy link
Contributor

Fixes #6778

@aringenbach aringenbach requested review from a team and gileluard and removed request for a team September 29, 2022 09:11
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

@gileluard gileluard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov
Copy link

codecov bot commented Sep 29, 2022

Codecov Report

Base: 10.11% // Head: 5.81% // Decreases project coverage by -4.30% ⚠️

Coverage data is based on head (0e023ba) compared to base (9cbf5dc).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #6779      +/-   ##
===========================================
- Coverage    10.11%    5.81%   -4.31%     
===========================================
  Files         1498     1496       -2     
  Lines       150968   150945      -23     
  Branches     60957    60908      -49     
===========================================
- Hits         15272     8770    -6502     
- Misses      135143   141783    +6640     
+ Partials       553      392     -161     
Impacted Files Coverage Δ
Riot/Utils/EventFormatter.m 10.02% <100.00%> (ø)
Riot/Categories/Character.swift 0.00% <0.00%> (-100.00%) ⬇️
...otSwiftUI/Modules/Common/Util/BorderModifier.swift 0.00% <0.00%> (-100.00%) ⬇️
...iftUI/Modules/Common/Avatar/Model/Avatarable.swift 0.00% <0.00%> (-100.00%) ⬇️
...iftUI/Modules/Common/Util/RoundedCornerShape.swift 0.00% <0.00%> (-100.00%) ⬇️
...odules/AnalyticsPrompt/AnalyticsPromptModels.swift 0.00% <0.00%> (-100.00%) ⬇️
...odules/Common/DependencyInjection/Injectable.swift 0.00% <0.00%> (-100.00%) ⬇️
...dules/Common/Theme/ThemeUsersColorsExtension.swift 0.00% <0.00%> (-100.00%) ⬇️
...dules/Common/ViewFrameReader/ViewFrameReader.swift 0.00% <0.00%> (-100.00%) ⬇️
...dules/UserSessions/Common/View/SeparatorLine.swift 0.00% <0.00%> (-100.00%) ⬇️
... and 243 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@aringenbach aringenbach merged commit 46a975b into develop Sep 29, 2022
@aringenbach aringenbach deleted the aringenbach/6778_fix_code_blocks_background_color branch September 29, 2022 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Code block background colour is missing when the new app layout is enabled
2 participants