Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to send message after filtering for room #6784

Merged

Conversation

gileluard
Copy link
Contributor

resolves #6755

Using the UIToolbar of the UINavigationController was not a great idea as the toolbar could overlap the UI when navigating (even if the toolbar was explicitly hidden). The AllChatsViewController has now its own toolbar to avoid this issue.

@gileluard gileluard requested review from a team and phloux and removed request for a team September 29, 2022 14:54
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Sep 29, 2022

Codecov Report

Base: 48.99% // Head: 5.94% // Decreases project coverage by -43.04% ⚠️

Coverage data is based on head (c351ad3) compared to base (b846c39).
Patch coverage: 57.69% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #6784       +/-   ##
============================================
- Coverage    48.99%    5.94%   -43.05%     
============================================
  Files          359     1498     +1139     
  Lines        13623   151157   +137534     
  Branches      5584    60989    +55405     
============================================
+ Hits          6675     8993     +2318     
- Misses        6778   141760   +134982     
- Partials       170      404      +234     
Impacted Files Coverage Δ
...Modules/Home/AllChats/AllChatsViewController.swift 28.34% <57.69%> (ø)
Riot/Categories/Character.swift 0.00% <0.00%> (-100.00%) ⬇️
...iftUI/Modules/Common/Avatar/Model/Avatarable.swift 0.00% <0.00%> (-100.00%) ⬇️
...iftUI/Modules/Common/Util/RoundedCornerShape.swift 0.00% <0.00%> (-100.00%) ⬇️
...odules/AnalyticsPrompt/AnalyticsPromptModels.swift 0.00% <0.00%> (-100.00%) ⬇️
...odules/Common/DependencyInjection/Injectable.swift 0.00% <0.00%> (-100.00%) ⬇️
...dules/Common/Theme/ThemeUsersColorsExtension.swift 0.00% <0.00%> (-100.00%) ⬇️
...dules/Common/ViewFrameReader/ViewFrameReader.swift 0.00% <0.00%> (-100.00%) ⬇️
...les/Onboarding/Avatar/OnboardingAvatarModels.swift 0.00% <0.00%> (-100.00%) ⬇️
...es/Room/PollEditForm/PollEditFormScreenState.swift 0.00% <0.00%> (-100.00%) ⬇️
... and 1464 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

QR code

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/V344We

@gileluard gileluard requested review from a team and aringenbach and removed request for phloux and a team September 30, 2022 07:39
Copy link
Contributor

@aringenbach aringenbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gileluard gileluard merged commit f4da3e2 into develop Sep 30, 2022
@gileluard gileluard deleted the gil/6755-Unable_to_send_message_after_filtering_for_room branch September 30, 2022 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to send message after filtering for room
2 participants