-
Notifications
You must be signed in to change notification settings - Fork 500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Session Manager: Single session logout #6803
Conversation
...UI/Modules/UserSessions/UserSessionOverview/Coordinator/UserSessionOverviewCoordinator.swift
Show resolved
Hide resolved
.../Modules/UserSessions/UserSessionsOverview/Coordinator/UserSessionsOverviewCoordinator.swift
Show resolved
Hide resolved
6f6ef69
to
4c2195f
Compare
4c2195f
to
aa910f3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of small comments, otherwise looks great!
RiotSwiftUI/Modules/UserSessions/UserSessionOverview/View/UserSessionOverviewItem.swift
Outdated
Show resolved
Hide resolved
RiotSwiftUI/Modules/UserSessions/Coordinator/UserSessionsFlowCoordinator.swift
Outdated
Show resolved
Hide resolved
RiotSwiftUI/Modules/UserSessions/Coordinator/UserSessionsFlowCoordinator.swift
Outdated
Show resolved
Hide resolved
Codecov ReportBase: 10.68% // Head: 10.71% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #6803 +/- ##
===========================================
+ Coverage 10.68% 10.71% +0.03%
===========================================
Files 1512 1512
Lines 151944 152116 +172
Branches 61268 61359 +91
===========================================
+ Hits 16228 16303 +75
- Misses 135143 135235 +92
- Partials 573 578 +5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
📱 Scan the QR code below to install the build for this PR. If you can't scan the QR code you can install the build via this link: https://i.diawi.com/MzeLhD |
Also fix a crash on iPad.
Kudos, SonarCloud Quality Gate passed! |
Adds the logout actions to both the current session section in the all sessions overview and to the single session overview screen as a button.
The UI for the rename action has been added but isn't hooked up to any logic yet.
Fixes #6802