Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Session Manager: Single session logout #6803

Merged
merged 2 commits into from
Oct 5, 2022
Merged

Conversation

pixlwave
Copy link
Member

@pixlwave pixlwave commented Oct 5, 2022

Adds the logout actions to both the current session section in the all sessions overview and to the single session overview screen as a button.

The UI for the rename action has been added but isn't hooked up to any logic yet.

Fixes #6802

Light Mode Dark Mode
Simulator Screen Recording - iPhone 13 mini - 2022-10-05 at 14 14 06 Simulator Screen Recording - iPhone 13 mini - 2022-10-05 at 14 14 59

@pixlwave pixlwave requested review from a team and phloux and removed request for a team and phloux October 5, 2022 12:01
@pixlwave pixlwave marked this pull request as draft October 5, 2022 12:10
@pixlwave pixlwave force-pushed the doug/session-manager-logout branch 2 times, most recently from 6f6ef69 to 4c2195f Compare October 5, 2022 13:18
@pixlwave pixlwave force-pushed the doug/session-manager-logout branch from 4c2195f to aa910f3 Compare October 5, 2022 13:33
@pixlwave pixlwave marked this pull request as ready for review October 5, 2022 13:34
@pixlwave pixlwave requested review from a team and stefanceriu and removed request for a team October 5, 2022 13:34
Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of small comments, otherwise looks great!

@codecov
Copy link

codecov bot commented Oct 5, 2022

Codecov Report

Base: 10.68% // Head: 10.71% // Increases project coverage by +0.03% 🎉

Coverage data is based on head (2c3826a) compared to base (cc5d0a1).
Patch coverage: 29.01% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #6803      +/-   ##
===========================================
+ Coverage    10.68%   10.71%   +0.03%     
===========================================
  Files         1512     1512              
  Lines       151944   152116     +172     
  Branches     61268    61359      +91     
===========================================
+ Hits         16228    16303      +75     
- Misses      135143   135235      +92     
- Partials       573      578       +5     
Impacted Files Coverage Δ
...eAuthentication/AuthenticatedEndpointRequest.swift 0.00% <0.00%> (ø)
...ions/Coordinator/UserSessionsFlowCoordinator.swift 0.00% <0.00%> (ø)
...r/UserSessionsFlowCoordinatorBridgePresenter.swift 0.00% <0.00%> (ø)
...w/Coordinator/UserSessionOverviewCoordinator.swift 0.00% <0.00%> (ø)
...SessionOverview/UserSessionOverviewViewModel.swift 66.66% <0.00%> (-6.51%) ⬇️
.../Coordinator/UserSessionsOverviewCoordinator.swift 0.00% <0.00%> (ø)
...rSessionsOverview/UserSessionsOverviewModels.swift 100.00% <ø> (ø)
...ssionsOverview/UserSessionsOverviewViewModel.swift 58.53% <16.66%> (-7.18%) ⬇️
...SessionOverview/View/UserSessionOverviewItem.swift 57.50% <42.10%> (ø)
...erSessionsOverview/View/UserSessionsOverview.swift 85.18% <81.25%> (-2.09%) ⬇️
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link

github-actions bot commented Oct 5, 2022

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

QR code

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/MzeLhD

Also fix a crash on iPad.
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 5, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@pixlwave pixlwave merged commit cb2207e into develop Oct 5, 2022
@pixlwave pixlwave deleted the doug/session-manager-logout branch October 5, 2022 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Device Manager: Single session logout
2 participants