-
Notifications
You must be signed in to change notification settings - Fork 500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check enabled field in notification settings push toggles #6815
Check enabled field in notification settings push toggles #6815
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM as far as i get it :) Just a tiny question.
📱 Scan the QR code below to install the build for this PR. If you can't scan the QR code you can install the build via this link: https://i.diawi.com/nNobXz |
Codecov ReportBase: 10.68% // Head: 10.73% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #6815 +/- ##
===========================================
+ Coverage 10.68% 10.73% +0.05%
===========================================
Files 1512 1512
Lines 151944 152247 +303
Branches 61268 61434 +166
===========================================
+ Hits 16228 16347 +119
- Misses 135143 135323 +180
- Partials 573 577 +4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
- Update after review
@ismailgulek agreed. The logic is quite tortured. Not sure the user will understand what's happening :) |
Kudos, SonarCloud Quality Gate passed! |
resolves #6814