Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check enabled field in notification settings push toggles #6815

Conversation

gileluard
Copy link
Contributor

resolves #6814

ezgif-5-6b62328432

@gileluard gileluard requested review from a team and ismailgulek and removed request for a team October 6, 2022 09:41
Copy link
Contributor

@ismailgulek ismailgulek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as far as i get it :) Just a tiny question.

@github-actions
Copy link

github-actions bot commented Oct 6, 2022

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

QR code

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/nNobXz

@codecov
Copy link

codecov bot commented Oct 6, 2022

Codecov Report

Base: 10.68% // Head: 10.73% // Increases project coverage by +0.05% 🎉

Coverage data is based on head (13cbfaf) compared to base (cc5d0a1).
Patch coverage: 5.46% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #6815      +/-   ##
===========================================
+ Coverage    10.68%   10.73%   +0.05%     
===========================================
  Files         1512     1512              
  Lines       151944   152247     +303     
  Branches     61268    61434     +166     
===========================================
+ Hits         16228    16347     +119     
- Misses      135143   135323     +180     
- Partials       573      577       +4     
Impacted Files Coverage Δ
...Service/MatrixSDK/UserSessionOverviewService.swift 0.00% <0.00%> (ø)
Riot/Modules/MatrixKit/Models/Account/MXKAccount.m 7.77% <5.64%> (-0.15%) ⬇️
...SplashScreen/OnboardingSplashScreenViewModel.swift 11.53% <0.00%> (-42.31%) ⬇️
...ssionsOverview/UserSessionsOverviewViewModel.swift 58.53% <0.00%> (-7.18%) ⬇️
...SessionOverview/UserSessionOverviewViewModel.swift 66.66% <0.00%> (-6.51%) ⬇️
...ing/SplashScreen/View/OnboardingSplashScreen.swift 54.05% <0.00%> (-4.06%) ⬇️
...erSessionsOverview/View/UserSessionsOverview.swift 85.18% <0.00%> (-2.09%) ⬇️
Riot/Modules/Settings/SettingsViewController.m 0.00% <0.00%> (ø)
...Modules/Settings/Security/SecurityViewController.m 0.00% <0.00%> (ø)
...s/Settings/Language/LanguagePickerViewController.m 0.00% <0.00%> (ø)
... and 18 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gileluard
Copy link
Contributor Author

@ismailgulek agreed. The logic is quite tortured. Not sure the user will understand what's happening :)

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 6, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@gileluard gileluard merged commit 4eb7a87 into develop Oct 6, 2022
@gileluard gileluard deleted the gil/6814-Check_enabled_field_in_notification_settings_push_toggles branch October 6, 2022 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check enabled field in notification settings push toggles
2 participants