WYSIWYG design improvements #6901
Conversation
…ements # Conflicts: # Riot.xcworkspace/xcshareddata/swiftpm/Package.resolved # project.yml
| @@ -40,13 +40,21 @@ struct Composer: View { | |||
| } | |||
|
|
|||
| private var cornerRadius: CGFloat { | |||
| viewModel.viewState.shouldDisplayContext ? 14 : borderHeight / 2 | |||
| if viewModel.viewState.shouldDisplayContext || wysiwygViewModel.idealHeight > minTextViewHeight { | |||
There was a problem hiding this comment.
Why is this line needed? I was thinking of removing idealHeight from the viewmodel. :)
There was a problem hiding this comment.
essentially Callum told me that we would like to have that when we have more than 1 single line in the text view, the corner radius of the border should be 14 instead of half the border height.
So by comparing the current ideal height with the minHeight I can determine if it has been increased from 1 single line to multiple lines, and decide which corner radius the view should display
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov ReportBase: 6.17% // Head: 6.14% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #6901 +/- ##
===========================================
- Coverage 6.17% 6.14% -0.03%
===========================================
Files 1571 1590 +19
Lines 156062 156558 +496
Branches 63028 63179 +151
===========================================
- Hits 9632 9627 -5
- Misses 146001 146503 +502
+ Partials 429 428 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
📱 Scan the QR code below to install the build for this PR. If you can't scan the QR code you can install the build via this link: https://i.diawi.com/26YuhT |
Improvements to match as closely as possible the Figma designs
RPReplay_Final1666023682.MP4