Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix for placeholder flickering in the normal and new composer when there is a height change. #6950

Merged
merged 1 commit into from
Oct 20, 2022

Conversation

Velin92
Copy link
Member

@Velin92 Velin92 commented Oct 20, 2022

Removed legacy lines of code which actually did nothing aside from cause the flickering of the placeholder.

@Velin92 Velin92 changed the title Bugfix for placeholder flickering in the normal and new composer when there is an height change. Bugfix for placeholder flickering in the normal and new composer when there is a height change. Oct 20, 2022
@Velin92 Velin92 linked an issue Oct 20, 2022 that may be closed by this pull request
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Member

@langleyd langleyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@codecov
Copy link

codecov bot commented Oct 20, 2022

Codecov Report

Base: 11.75% // Head: 11.75% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (217d073) compared to base (4db5962).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #6950   +/-   ##
========================================
  Coverage    11.75%   11.75%           
========================================
  Files         1594     1594           
  Lines       156693   156686    -7     
  Branches     63313    63310    -3     
========================================
+ Hits         18421    18424    +3     
+ Misses      137651   137641   -10     
  Partials       621      621           
Flag Coverage Δ
uitests 54.86% <ø> (ø)
unittests 6.14% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
Riot/Modules/Room/RoomViewController.m 0.00% <ø> (ø)
...ojiPicker/Data/EmojiMart/EmojiItem+EmojiMart.swift 95.65% <0.00%> (+0.30%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Velin92 Velin92 merged commit c3d2df0 into develop Oct 20, 2022
@Velin92 Velin92 deleted the mauroromito/6949_placeholder_flickering_bugfix branch October 20, 2022 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Placeholder text in the Input Toolbar Flickering
2 participants