Threads: added support to read receipts (MSC3771) #6964
Conversation
Codecov ReportBase: 11.78% // Head: 11.77% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #6964 +/- ##
===========================================
- Coverage 11.78% 11.77% -0.02%
===========================================
Files 1611 1608 -3
Lines 158118 158028 -90
Branches 64239 64044 -195
===========================================
- Hits 18631 18603 -28
+ Misses 138858 138790 -68
- Partials 629 635 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
| MXKRoomBubbleCellData *cellData = [self cellDataOfEventWithEventId:eventId]; | ||
| if (cellData) | ||
| { | ||
| NSString *threadId = readThreadIds[i] == [NSNull null] ? kMXEventTimelineMain : readThreadIds[i]; |
There was a problem hiding this comment.
We could simplify this after https://github.com/matrix-org/matrix-ios-sdk/pull/1617/files#r1004308936
There was a problem hiding this comment.
Unthreaded RRs must be propagated to all threads. I've made the needed changes.
| @@ -68,7 +68,7 @@ final class ThreadsCoordinator: NSObject, ThreadsCoordinatorProtocol { | |||
| // Detect when view controller has been dismissed by gesture when presented modally (not in full screen). | |||
| self.navigationRouter.toPresentable().presentationController?.delegate = self | |||
|
|
|||
| guard parameters.threadId == nil else { | |||
| guard parameters.threadId != nil else { | |||
There was a problem hiding this comment.
I can't remember what this was doing but can you explain this change a bit?
There was a problem hiding this comment.
I removed the guard as we need the pop completion block to be triggered for all cases. RoomViewControllers where not released when popped and RR where still sent even if the messages were not read.
- Update after review
- Update after review
|
Kudos, SonarCloud Quality Gate passed!
|
resolves #6663