Rich Text Composer - Maximise/Minimise toggle #6971
Conversation
| wysiwygViewModel.$idealHeight | ||
| .removeDuplicates() | ||
| .sink { [weak hostingViewController] _ in | ||
| hostingViewController?.view.setNeedsLayout() |
There was a problem hiding this comment.
Maybe a comment to describe why this is needed?
There was a problem hiding this comment.
Fixes that bug that made the view stay centered and expanded when it is maximised and then minimised.
Essentially the superview does not recognize the change back to the minimised form, and does not layout again its subviews. By listening to the ideal height changes, it forces the super view to do another layout again.
|
📱 Scan the QR code below to install the build for this PR. If you can't scan the QR code you can install the build via this link: https://i.diawi.com/pVwYyR |
Codecov ReportBase: 11.67% // Head: 11.67% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #6971 +/- ##
=========================================
Coverage 11.67% 11.67%
=========================================
Files 1607 1608 +1
Lines 157726 157916 +190
Branches 63719 63894 +175
=========================================
+ Hits 18414 18442 +28
- Misses 138691 138852 +161
- Partials 621 622 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
Kudos, SonarCloud Quality Gate passed!
|
No description provided.