Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Poll not usable after logging out and back in #7072

Merged
merged 3 commits into from
Nov 14, 2022

Conversation

paleksandrs
Copy link
Contributor

Closes #7070

Fix for

After I logged out and in again I had four bug cases:

  • I could not end the poll (pressing the button did nothing)
  • I could not see changed votes by others
  • I could not see the closed poll after someone else closed it
  • When I changed my vote, the others did not get an event from me.

@paleksandrs paleksandrs requested review from a team and gileluard and removed request for a team November 14, 2022 08:49
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

@gileluard gileluard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov
Copy link

codecov bot commented Nov 14, 2022

Codecov Report

Base: 11.72% // Head: 11.75% // Increases project coverage by +0.03% 🎉

Coverage data is based on head (d769f01) compared to base (2184f1f).
Patch coverage: 28.31% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7072      +/-   ##
===========================================
+ Coverage    11.72%   11.75%   +0.03%     
===========================================
  Files         1613     1620       +7     
  Lines       158529   158739     +210     
  Branches     64369    64569     +200     
===========================================
+ Hits         18589    18667      +78     
- Misses      139305   139435     +130     
- Partials       635      637       +2     
Flag Coverage Δ
uitests 54.92% <47.03%> (+0.44%) ⬆️
unittests 5.96% <5.16%> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
Config/BuildSettings.swift 43.07% <ø> (ø)
Riot/Categories/MXKRoomBubbleTableViewCell+Riot.m 0.00% <0.00%> (ø)
Riot/Managers/Settings/RiotSettings.swift 88.33% <ø> (-0.10%) ⬇️
Riot/Modules/Room/RoomViewController.m 0.00% <0.00%> (ø)
.../WYSIWYGInputToolbar/WysiwygInputToolbarView.swift 0.00% <0.00%> (ø)
Riot/Modules/TabBar/MasterTabBarController.m 0.00% <0.00%> (ø)
RiotSwiftUI/Modules/Common/Extensions/View.swift 0.00% <0.00%> (ø)
...n/InfoSheet/Coordinator/InfoSheetCoordinator.swift 0.00% <0.00%> (ø)
.../Modules/Common/InfoSheet/InfoSheetViewModel.swift 0.00% <0.00%> (ø)
...es/Common/InfoSheet/MockInfoSheetScreenState.swift 0.00% <0.00%> (ø)
... and 58 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@paleksandrs paleksandrs merged commit 2630bbf into develop Nov 14, 2022
@paleksandrs paleksandrs deleted the aleksandrs/7070_poll_no_usable branch November 14, 2022 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Poll not usable after logging out and back in
2 participants