Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Rich text Editor Fullscreen dragging through dismiss #7117

Conversation

Velin92
Copy link
Member

@Velin92 Velin92 commented Nov 29, 2022

No description provided.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@aringenbach aringenbach self-requested a review November 29, 2022 11:40
@codecov
Copy link

codecov bot commented Nov 29, 2022

Codecov Report

Base: 11.73% // Head: 11.71% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (718cc01) compared to base (05af299).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7117      +/-   ##
===========================================
- Coverage    11.73%   11.71%   -0.02%     
===========================================
  Files         1620     1620              
  Lines       159273   159264       -9     
  Branches     64808    64798      -10     
===========================================
- Hits         18687    18658      -29     
- Misses      139942   139970      +28     
+ Partials       644      636       -8     
Flag Coverage Δ
uitests 54.83% <ø> (+0.03%) ⬆️
unittests 5.93% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
Riot/Modules/Room/RoomViewController.swift 0.00% <0.00%> (ø)
...xKit/Controllers/MXKAuthenticationViewController.m 17.04% <0.00%> (-1.92%) ⬇️
...castPlayback/View/VoiceBroadcastPlaybackView.swift 0.00% <0.00%> (ø)
...ojiPicker/Data/EmojiMart/EmojiItem+EmojiMart.swift 95.34% <0.00%> (+4.04%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@aringenbach aringenbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Velin92 Velin92 merged commit 2187790 into develop Nov 29, 2022
@Velin92 Velin92 deleted the mauroromito/7116_fix_rich_text_dismiss_when_dragging_fullscreen branch November 29, 2022 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rich Text Editor: Fullscreen dragging dismissal doesn't always work when there is a lot of text
2 participants