Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send voice message should not be allowed during a voice broadcast recording (#7235) #7245

Merged
merged 1 commit into from
Jan 9, 2023

Conversation

nimau
Copy link
Contributor

@nimau nimau commented Jan 9, 2023

Fix #7235

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Jan 9, 2023

Codecov Report

Base: 11.83% // Head: 11.83% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (3ba73df) compared to base (daea28b).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7245      +/-   ##
===========================================
- Coverage    11.83%   11.83%   -0.01%     
===========================================
  Files         1629     1629              
  Lines       160154   160212      +58     
  Branches     65386    65412      +26     
===========================================
+ Hits         18962    18965       +3     
- Misses      140555   140610      +55     
  Partials       637      637              
Flag Coverage Δ
uitests 54.84% <ø> (ø)
unittests 5.96% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
Riot/Modules/Room/RoomViewController.m 0.00% <0.00%> (ø)
...es/Room/VoiceMessages/VoiceMessageController.swift 0.00% <0.00%> (ø)
...r/Coordinator/VoiceBroadcastRecorderProvider.swift 0.00% <0.00%> (ø)
...oordinator/VoiceBroadcastRecorderCoordinator.swift 0.00% <0.00%> (ø)
...vice/MatrixSDK/VoiceBroadcastRecorderService.swift 0.00% <0.00%> (ø)
...ojiPicker/Data/EmojiMart/EmojiItem+EmojiMart.swift 95.65% <0.00%> (+0.30%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@nimau nimau merged commit b1b2a4b into develop Jan 9, 2023
@nimau nimau deleted the nimau/7235_prevent_new_voicemessage_during_VB branch January 9, 2023 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Send voice message should not be allowed during a voice broadcast recording
2 participants