Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle a connection issue when we try to start a new voice broadcast #7276

Merged
merged 4 commits into from
Jan 17, 2023

Conversation

yostyle
Copy link
Contributor

@yostyle yostyle commented Jan 16, 2023

@codecov
Copy link

codecov bot commented Jan 16, 2023

Codecov Report

Base: 11.92% // Head: 11.91% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (abea032) compared to base (a9ff128).
Patch coverage: 0.00% of modified lines in pull request are covered.

❗ Current head abea032 differs from pull request most recent head f5aa329. Consider uploading reports for the commit f5aa329 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7276      +/-   ##
===========================================
- Coverage    11.92%   11.91%   -0.01%     
===========================================
  Files         1633     1633              
  Lines       160744   160752       +8     
  Branches     65700    65703       +3     
===========================================
- Hits         19163    19160       -3     
- Misses      140942   140953      +11     
  Partials       639      639              
Flag Coverage Δ
uitests 55.21% <ø> (-0.02%) ⬇️
unittests 5.96% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
Riot/Modules/Room/RoomViewController.m 0.00% <0.00%> (ø)
...cast/VoiceBroadcastSDK/VoiceBroadcastService.swift 0.00% <0.00%> (ø)
...ingViewer/LiveLocationSharingViewerViewModel.swift 52.63% <0.00%> (-1.76%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@phloux phloux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The towncrier file is missing in your PR.

@yostyle yostyle force-pushed the yostyle/voicebroadcast_connection_error branch from ecb2c21 to abea032 Compare January 17, 2023 09:56
@yostyle yostyle requested a review from phloux January 17, 2023 09:57
Copy link
Contributor

@phloux phloux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yostyle yostyle changed the title Handle a connexion issue when we try to start a new voice broadcast Handle a connection issue when we try to start a new voice broadcast Jan 17, 2023
@yostyle yostyle force-pushed the yostyle/voicebroadcast_connection_error branch from 3150461 to f5aa329 Compare January 17, 2023 14:40
@yostyle yostyle requested review from nimau and removed request for nimau January 17, 2023 14:41
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

@nimau nimau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yostyle yostyle merged commit 02477cc into develop Jan 17, 2023
@yostyle yostyle deleted the yostyle/voicebroadcast_connection_error branch January 17, 2023 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants