Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix voicebroadcast playback slider on seek #7277

Merged
merged 1 commit into from
Jan 18, 2023

Conversation

nimau
Copy link
Contributor

@nimau nimau commented Jan 17, 2023

Fixes #7252

This PR resolves the following issues on the Voice Broadcast audio player:

  • the progress bar did not behave as expected after a seek.
  • the progress bar did not always reach the end after the playback was finished.
  • the displayLink was not paused when stopping or pausing the audio player.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@nimau nimau added T-Defect Something isn't working: bugs, crashes, hangs and other reported problems A-Voice-Broadcast labels Jan 17, 2023
Copy link
Contributor

@yostyle yostyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Jan 17, 2023

Codecov Report

Base: 11.92% // Head: 11.92% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (f685d6f) compared to base (a9ff128).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7277      +/-   ##
===========================================
- Coverage    11.92%   11.92%   -0.01%     
===========================================
  Files         1633     1633              
  Lines       160744   160758      +14     
  Branches     65700    65707       +7     
===========================================
  Hits         19163    19163              
- Misses      140942   140956      +14     
  Partials       639      639              
Flag Coverage Δ
uitests 55.23% <ø> (ø)
unittests 5.96% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ck/MatrixSDK/VoiceBroadcastPlaybackViewModel.swift 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@nimau nimau merged commit e08ec5d into develop Jan 18, 2023
@nimau nimau deleted the nimau/7252_vb_seek_enhancement branch January 18, 2023 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Voice-Broadcast T-Defect Something isn't working: bugs, crashes, hangs and other reported problems
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The 30s back / forward buttons are jumping back and forth erratically when tapped
3 participants