Fix Space Switcher avatars

[pixlwave]

Fixes #7305. The view model is now injected at a top level and shared across multiple avatars so no longer works with the state being held within the model. As this is a lightweight component it seems reasonable to me to move it to an @State variable within the view itself.

Note: Also fixes the same bug in user suggestions and possibly elsewhere in SwiftUI.

Before	After

[pixlwave]

Maybe at this stage we should rename this to AvatarLoader/AvatarProvider?

[codecov]

Codecov Report

Base: 11.97% // Head: 11.98% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (4f61755) compared to base (06c572e).
Patch coverage: 73.33% of modified lines in pull request are covered.

Additional details and impacted files

@@              Coverage Diff               @@
##           hotfix/1.9.16    #7306   +/-   ##
==============================================
  Coverage          11.97%   11.98%           
==============================================
  Files               1634     1634           
  Lines             161034   161045   +11     
  Branches           65131    65159   +28     
==============================================
+ Hits               19291    19301   +10     
- Misses            141101   141102    +1     
  Partials             642      642           

Flag	Coverage Δ
uitests	55.36% <73.33%> (+0.02%)	⬆️
unittests	5.95% <0.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
.../Modules/Common/Avatar/View/SpaceAvatarImage.swift	39.72% <54.54%> (+1.49%)	⬆️
...ules/Common/Avatar/ViewModel/AvatarViewModel.swift	90.00% <90.90%> (-2.86%)	⬇️
...iftUI/Modules/Common/Avatar/View/AvatarImage.swift	71.42% <91.66%> (+0.24%)	⬆️
...ingViewer/LiveLocationSharingViewerViewModel.swift	54.38% <0.00%> (+1.75%)	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[alfogrillo]

LGTM! 🎉

I'm not sure why we need both SpaceAvatarImage and AvatarImage.
But it isn't really related with this PR.

[pixlwave]

I'm not sure why we need both SpaceAvatarImage and AvatarImage. But it isn't really related with this PR.

Yeah they could share more code for sure - at a component level its because space avatars are square and normal ones are round though.