Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix partial text messages not being saved for each room with RTE enabled #7536

Merged
merged 3 commits into from
May 5, 2023

Conversation

aringenbach
Copy link
Contributor

Fixes #7535

Also updates the RTE library version to 2.1.0 and apply API changes. See CHANGELOG for details.

Simulator.Screen.Recording.-.iPhone.SE.3rd.generation.-.2023-05-03.at.14.51.09.mp4

@aringenbach aringenbach requested review from a team and nimau and removed request for a team May 3, 2023 13:04
Copy link
Contributor

@nimau nimau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud
Copy link

sonarqubecloud bot commented May 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented May 3, 2023

Codecov Report

Patch coverage: 3.84% and project coverage change: -0.01 ⚠️

Comparison is base (379e8e2) 12.22% compared to head (5559e1c) 12.22%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7536      +/-   ##
===========================================
- Coverage    12.22%   12.22%   -0.01%     
===========================================
  Files         1646     1646              
  Lines       163363   163408      +45     
  Branches     67063    67079      +16     
===========================================
+ Hits         19968    19971       +3     
- Misses      142752   142794      +42     
  Partials       643      643              
Flag Coverage Δ
uitests 55.06% <100.00%> (ø)
unittests 6.06% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...t/Views/RoomInputToolbar/MXKRoomInputToolbarView.m 0.00% <0.00%> (ø)
Riot/Modules/Room/MXKRoomViewController.m 0.00% <0.00%> (ø)
Riot/Modules/Room/RoomViewController.m 0.00% <0.00%> (ø)
.../WYSIWYGInputToolbar/WysiwygInputToolbarView.swift 0.00% <0.00%> (ø)
...LinkAction/MockComposerLinkActionScreenState.swift 100.00% <100.00%> (ø)
...Action/ViewModel/ComposerLinkActionViewModel.swift 41.17% <100.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@aringenbach aringenbach merged commit bedcbc3 into develop May 5, 2023
@aringenbach aringenbach deleted the aringenbach/7535_fix_partial_text_messages branch May 5, 2023 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Labs: Rich Text Editor: Partial text messages are not saved
2 participants