Prompt the user when the invited MatrixId is not recognized #7571
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## develop #7571 +/- ##
===========================================
- Coverage 12.22% 12.21% -0.01%
===========================================
Files 1648 1648
Lines 163591 163637 +46
Branches 67156 67177 +21
===========================================
Hits 19992 19992
- Misses 142954 143000 +46
Partials 645 645
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
| self.displayInvitePrompt(contact: contact, contactFound: false) | ||
| }) | ||
| } else { | ||
| displayInvitePrompt(contact: contact) |
There was a problem hiding this comment.
Just checking with you this branch:
is it correct calling displayInvitePrompt with contactFound: true when MXTools.isMatrixUserIdentifier returns false?
There was a problem hiding this comment.
yes this is correct. FYI This was the previous behaviour before we decided to handle specifically the case where the selected contact is a mxId
There was a problem hiding this comment.
perhaps the boolean should be renamed isKnownProfile or isKnownUser
or the opposite isUnknownProfile (isUnknownUser)
I would prefer the last option isUnknownUser
There was a problem hiding this comment.
Ok, it makes sense now! 👍🏻
LGTM, renaming as suggested above would be better.
|
Kudos, SonarCloud Quality Gate passed!
|
This PR applies the change requested by #7558