-
Notifications
You must be signed in to change notification settings - Fork 499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MediaPicker list albums under ios18 #7888
base: develop
Are you sure you want to change the base?
MediaPicker list albums under ios18 #7888
Conversation
…com:NicolasBuquet/element-ios-tchap into nbuquet/mediapicker-list-albums-under-ios18
…com:NicolasBuquet/element-ios-tchap into nbuquet/mediapicker-list-albums-under-ios18 Signed-off-by: Nicolas Buquet <[email protected]>
…com:NicolasBuquet/element-ios-tchap into nbuquet/mediapicker-list-albums-under-ios18
…com:NicolasBuquet/element-ios-tchap into nbuquet/mediapicker-list-albums-under-ios18
…com:NicolasBuquet/element-ios-tchap into nbuquet/mediapicker-list-albums-under-ios18
…com:NicolasBuquet/element-ios-tchap into nbuquet/mediapicker-list-albums-under-ios18
…com:NicolasBuquet/element-ios-tchap into nbuquet/mediapicker-list-albums-under-ios18
@pixlwave Can you have a look 🙏 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #7888 +/- ##
============================================
+ Coverage 15.08% 62.18% +47.10%
============================================
Files 1810 504 -1306
Lines 173591 21096 -152495
Branches 67305 7962 -59343
============================================
- Hits 26185 13119 -13066
+ Misses 147370 7951 -139419
+ Partials 36 26 -10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Thanks for the PR @NicolasBuquet, but I'm unable to reproduce the bug you mention. Version 1.11.22 on iOS 18.2.1 looks like this: |
@pixlwave Strange. |
Since iOS 18, the MediaPicker doesn't list albums anymore. Just a few recent pictures.
Albums handling in Photos Apple application did change in iOS 18.
This fix list any album rather than Smart Albums.
Pull Request Checklist