Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MediaPicker list albums under ios18 #7888

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from

Conversation

NicolasBuquet
Copy link

Since iOS 18, the MediaPicker doesn't list albums anymore. Just a few recent pictures.

Albums handling in Photos Apple application did change in iOS 18.

This fix list any album rather than Smart Albums.

Pull Request Checklist

  • I read the contributing guide
  • UI change has been tested on both light and dark themes, in portrait and landscape orientations and on iPhone and iPad simulators
  • Accessibility has been taken into account.
  • Pull request is based on the develop branch
  • Pull request contains a changelog file in ./changelog.d
  • You've made a self review of your PR
  • Pull request includes screenshots or videos of UI changes
  • Pull request includes a sign off

…com:NicolasBuquet/element-ios-tchap into nbuquet/mediapicker-list-albums-under-ios18
…com:NicolasBuquet/element-ios-tchap into nbuquet/mediapicker-list-albums-under-ios18

Signed-off-by: Nicolas Buquet <[email protected]>
…com:NicolasBuquet/element-ios-tchap into nbuquet/mediapicker-list-albums-under-ios18
@CLAassistant
Copy link

CLAassistant commented Jan 2, 2025

CLA assistant check
All committers have signed the CLA.

…com:NicolasBuquet/element-ios-tchap into nbuquet/mediapicker-list-albums-under-ios18
…com:NicolasBuquet/element-ios-tchap into nbuquet/mediapicker-list-albums-under-ios18
…com:NicolasBuquet/element-ios-tchap into nbuquet/mediapicker-list-albums-under-ios18
…com:NicolasBuquet/element-ios-tchap into nbuquet/mediapicker-list-albums-under-ios18
@NicolasBuquet
Copy link
Author

@pixlwave Can you have a look 🙏

Copy link

codecov bot commented Jan 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.18%. Comparing base (d8bcc18) to head (9780158).
Report is 14 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #7888       +/-   ##
============================================
+ Coverage    15.08%   62.18%   +47.10%     
============================================
  Files         1810      504     -1306     
  Lines       173591    21096   -152495     
  Branches     67305     7962    -59343     
============================================
- Hits         26185    13119    -13066     
+ Misses      147370     7951   -139419     
+ Partials        36       26       -10     
Flag Coverage Δ
uitests 62.18% <ø> (+9.43%) ⬆️
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pixlwave
Copy link
Member

pixlwave commented Jan 7, 2025

Thanks for the PR @NicolasBuquet, but I'm unable to reproduce the bug you mention. Version 1.11.22 on iOS 18.2.1 looks like this:

IMG_A553567313FF-1

@NicolasBuquet
Copy link
Author

@pixlwave Strange.
Here are 2 screenshots under iOS 18.2 (not 18.2.1) without patch:
IMG_0736

and with patch:
IMG_0737

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants