Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We should be more aggressive about pinning our deps. #10

Closed
ara4n opened this issue Aug 29, 2015 · 2 comments
Closed

We should be more aggressive about pinning our deps. #10

ara4n opened this issue Aug 29, 2015 · 2 comments
Labels
P2 T-Task Tasks for the team like planning

Comments

@ara4n
Copy link
Member

ara4n commented Aug 29, 2015

Need to go through turning ^s to ~s in package.json for JS and React SDK to ensure 'minor' package updates don't break the world (like we just had with flux going from 2.1 to 2.2)

@ara4n ara4n added T-Defect T-Task Tasks for the team like planning and removed T-Defect labels Aug 29, 2015
@ara4n ara4n added P2 T-Task Tasks for the team like planning and removed T-Task Tasks for the team like planning labels Sep 7, 2015
@ara4n ara4n modified the milestone: Ragnarok Nov 29, 2015
@ara4n ara4n removed this from the Ragnarok milestone Apr 13, 2016
@kyrias
Copy link

kyrias commented Sep 24, 2016

If a minor update broke things that would be a bug from flux though, and the same thing could happen with a patch release, so I'm not sure what that would really solve.

@richvdh
Copy link
Member

richvdh commented Oct 20, 2016

I'm with kyrias. I don't think we're going to do this.

@richvdh richvdh closed this as completed Oct 20, 2016
dtygel pushed a commit to coletivoEITA/riot-web that referenced this issue May 4, 2017
t3chguy pushed a commit that referenced this issue Oct 17, 2024
Update repos for changelog fetching
JohnSimonsen pushed a commit to verji/element-web-v2 that referenced this issue Dec 20, 2024
* Upgrade dependency to [email protected]

* v3.94.0-rc.0

* Handle up/down as well as left/right for horizontal toolbars for improved a11y (element-hq#12305)

Signed-off-by: Michael Telatynski <[email protected]>

* Remove references to internal js-sdk type `CryptoBackend` (element-hq#12321)

* Remove references to internal js-sdk type `CryptoBackend`

* Use `Paramteters` to avoid `ts-ignore`

* Use `strong` element to semantically denote visually emphasised content (element-hq#12320)

* Use `strong` element to semantically denote visually emphasised content

Signed-off-by: Michael Telatynski <[email protected]>

* Update snapshots

Signed-off-by: Michael Telatynski <[email protected]>

* Add comment

Signed-off-by: Michael Telatynski <[email protected]>

---------

Signed-off-by: Michael Telatynski <[email protected]>

* Remove unused slider component (element-hq#12303)

It is unused as of matrix-org/matrix-react-sdk#12246. I noticed this while working on matrix-org/matrix-react-sdk#12299.

* Update matrix-org (element-hq#11966)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update all non-major dependencies (element-hq#12322)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update dependency stylelint-scss to v6.2.0 (element-hq#12323)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update dependency @vector-im/compound-web to v3.1.3 (element-hq#12281)

* Update dependency @vector-im/compound-web to v3.1.3

* Update snapshots

Signed-off-by: Michael Telatynski <[email protected]>

* Update snapshots

Signed-off-by: Michael Telatynski <[email protected]>

* Update snapshots

Signed-off-by: Michael Telatynski <[email protected]>

* Fix TAC width due to compound update (element-hq#12326)

---------

Signed-off-by: Michael Telatynski <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Michael Telatynski <[email protected]>
Co-authored-by: Florian Duros <[email protected]>

* Call guest access link creation to join calls as a non registered user via the EC SPA (element-hq#12259)

* Add externall call link button if in public call room

Signed-off-by: Timo K <[email protected]>

* Allow configuring a spa homeserver url.

Signed-off-by: Timo K <[email protected]>

* temp

Signed-off-by: Timo K <[email protected]>

* remove homeserver url

Signed-off-by: Timo K <[email protected]>

* Add custom title to share dialog.
So that we can use it as a "share call" dialog.

Signed-off-by: Timo K <[email protected]>

* - rename config options
- only show link button if a guest url is provided
- share dialog custom Title
- rename call share labels

Signed-off-by: Timo K <[email protected]>

* rename to title_link

Signed-off-by: Timo K <[email protected]>

* add tests for ShareDialog

Signed-off-by: Timo K <[email protected]>

* add tests for share call button

Signed-off-by: Timo K <[email protected]>

* review

Signed-off-by: Timo K <[email protected]>

* remove comment

Signed-off-by: Timo K <[email protected]>

* Update src/components/views/dialogs/ShareDialog.tsx

Co-authored-by: David Baker <[email protected]>

---------

Signed-off-by: Timo K <[email protected]>
Co-authored-by: David Baker <[email protected]>

* Fix spotlight opening in TAC (element-hq#12315)

* Fix spotlight opening in TAC

* Add tests

* Remove `RovingTabIndexProvider`

* Reset power selector on API failure to prevent state mismatch (element-hq#12319)

* Reset power selector on API failure to prevent state mismatch

Signed-off-by: Michael Telatynski <[email protected]>

* Allow onChange to be sync or async

Signed-off-by: Michael Telatynski <[email protected]>

* Add unmounted check

Signed-off-by: Michael Telatynski <[email protected]>

* Improve coverage

Signed-off-by: Michael Telatynski <[email protected]>

* Iterate

Signed-off-by: Michael Telatynski <[email protected]>

---------

Signed-off-by: Michael Telatynski <[email protected]>

* Use correct push rule to evaluate room-wide mentions (element-hq#12318)

Signed-off-by: Michael Telatynski <[email protected]>

* Improve Forward Dialog a11y by switching to roving tab index interactions (#12306)

* Improve Forward Dialog a11y by switching to roving tab index interactions

Signed-off-by: Michael Telatynski <[email protected]>

* Improve screen reader readout

Signed-off-by: Michael Telatynski <[email protected]>

* Improve screen reader readout

Signed-off-by: Michael Telatynski <[email protected]>

* Add tests

Signed-off-by: Michael Telatynski <[email protected]>

---------

Signed-off-by: Michael Telatynski <[email protected]>

* [create-pull-request] automated change (element-hq#12330)

Co-authored-by: github-merge-queue <[email protected]>

* Reuse media content/info types from the js-sdk (element-hq#12308)

* TAC: Fix CSS & component typos (element-hq#12333)

* Fix CSS & component typo

* Update snapshots

* Element Call: fix widget shown while its still loading (`waitForIframeLoad=false`) (element-hq#12292)

* show loading spinner also if waitForIframeLoad = false
Configure EC so it waits for the content loaded action
!WARNING This breaks compatibility with the full mesh branch.
I would like to discuss here if/when we can do that.

Signed-off-by: Timo K <[email protected]>

* stop show loading screen on widget ready (instead of preparing)

Signed-off-by: Timo K <[email protected]>

* wait until widget loading is over before comparing screenshots

Signed-off-by: Timo K <[email protected]>

* fix waitForIFrame=true widgets

Signed-off-by: Timo K <[email protected]>

* test

Signed-off-by: Timo K <[email protected]>

* always start with loading true. + cleanup

Signed-off-by: Timo K <[email protected]>

* simplify loading

Signed-off-by: Timo K <[email protected]>

* update snapshots (start not in loading state for waitForIframe = true widgets)

Signed-off-by: Timo K <[email protected]>

---------

Signed-off-by: Timo K <[email protected]>

* Upgrade dependency to [email protected]

* v3.94.0

* Resetting package fields for development

* Reset matrix-js-sdk back to develop branch

---------

Signed-off-by: Michael Telatynski <[email protected]>
Signed-off-by: Timo K <[email protected]>
Co-authored-by: RiotRobot <[email protected]>
Co-authored-by: Michael Telatynski <[email protected]>
Co-authored-by: Richard van der Hoff <[email protected]>
Co-authored-by: Robin <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Florian Duros <[email protected]>
Co-authored-by: Timo <[email protected]>
Co-authored-by: David Baker <[email protected]>
Co-authored-by: github-merge-queue <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 T-Task Tasks for the team like planning
Projects
None yet
Development

No branches or pull requests

3 participants