Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small ux improvements to aliases #13501

Closed
2 tasks done
foldleft opened this issue May 5, 2020 · 2 comments
Closed
2 tasks done

Small ux improvements to aliases #13501

foldleft opened this issue May 5, 2020 · 2 comments

Comments

@foldleft
Copy link
Contributor

foldleft commented May 5, 2020 •
edited
Loading

Per #13077 (comment)

  • Inline progress feedback when adding aliases
  • Indicate what the attempted change was in the error message
@foldleft foldleft self-assigned this May 5, 2020
foldleft added a commit to matrix-org/matrix-react-sdk that referenced this issue May 11, 2020
@foldleft
Refactor of alt aliases to use react hooks
5f75726 
This should have some nicer behavior that will confused users less

See element-hq/element-web#13501
This was referenced May 11, 2020
Closed
Open
@foldleft foldleft removed their assignment Aug 4, 2020
@aaronraimist
Copy link
Collaborator

The improvements listed here are checked off but the PR was closed without being merged and I don't think they ever happened in another PR. What happened?

@t3chguy
Copy link
Member

t3chguy commented Nov 9, 2020

The author is no longer involved. Closing in favour of the broader #13077

@t3chguy t3chguy closed this as completed Nov 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improvements to alt aliases matrix-org/matrix-react-sdk
3 participants
@t3chguy @foldleft @aaronraimist