Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

leftpanel blur sometimes disappears for a frame on Chrome, flashing your avatar at you. #14531

Closed
ara4n opened this issue Jul 16, 2020 · 15 comments

Comments

@ara4n
Copy link
Member

ara4n commented Jul 16, 2020

on Chrome 83.0.4103.116 on macOS 10.15.5 using integrated graphics, every ~1 hour or so something causes the LeftPanel to refresh in such a way that the background-blur and also 80% opaque background vanishes for a single frame on the LeftPanel (but not the LLP, i /think/). This is very disconcerting, as it causes a subliminal flash of your face suddenly peering back at you from the RoomList. I assume this might be React remounting the RoomList somehow? It may coincide with changing rooms; i haven't spotted the pattern yet.

@ara4n
Copy link
Member Author

ara4n commented Jul 16, 2020

just had it again, this time just when hoverovering the breadcrumbs while filtered, so it's not related to switching room.

@ara4n
Copy link
Member Author

ara4n commented Jul 16, 2020

and again, this time when scrolling the roomlist via two-finger swipes

@turt2live
Copy link
Member

for me this was happening because of a [x] disable cache checkbox - does that roughly align with what you were seeing?

@ara4n ara4n changed the title leftpanel blur sometimes disappears for a frame on Chrome leftpanel blur sometimes disappears for a frame on Chrome, flashing your avatar at you. Jul 16, 2020
@turt2live turt2live added the X-Needs-Info This issue is blocked awaiting information from the reporter label Jul 16, 2020
@ara4n
Copy link
Member Author

ara4n commented Jul 16, 2020

my 'disable cache' is not checked.

i've been able to reproduce quite a lot when scrolling both room history and leftpanel and breadcrumbs, but not when screencapturing.

@turt2live
Copy link
Member

it might just be that disabling the cache exacerbates the issue rather than causes it. With cache disabled, the image flickers a lot presumably with every mount or layout change - it's possible that what you're seeing is the same thing, however most people will not see the effect happening.

Maybe we can download and convert the avatar to a blob to avoid relying on http and potential delays there?

@turt2live turt2live removed the X-Needs-Info This issue is blocked awaiting information from the reporter label Jul 16, 2020
@ara4n
Copy link
Member Author

ara4n commented Jul 16, 2020

i'm wondering if we're talking about remotely the same thing. i don't think there's any reason that the avatar should be reloaded, least of all via http from the network? it looks more like a GPU rendering bug, where sometimes incomplete layers are being swapbuffered...

@turt2live
Copy link
Member

it kinda sounds like we are: we set the avatar URL on every render, which is often.

https://github.com/matrix-org/matrix-react-sdk/blob/b1444146e632579e58575814786c7d0ba1fd9607/src/components/structures/UserMenu.tsx#L311

@ara4n
Copy link
Member Author

ara4n commented Jul 17, 2020

This is weirdly more and more reproduceable for me. Have uploaded a video (internal only) at https://matrix.to/#/!RbKRuLTvHIhArQcvjr:matrix.org/$1594995153111370IMyax:matrix.org?via=matrix.org&via=t2l.io&via=riot.ovh

@ara4n
Copy link
Member Author

ara4n commented Sep 17, 2020

i get this constantly, fwiw, and it's incredibly ugly. (not just 'cos it's my face)

@turt2live
Copy link
Member

from what I remember it's a mac-specific issue.

@turt2live turt2live removed their assignment Sep 17, 2020
@t3chguy
Copy link
Member

t3chguy commented Sep 17, 2020

I had it on my windows 10 laptop but rarely, get it a bit more frequently on my MacBook though

@ara4n
Copy link
Member Author

ara4n commented Apr 16, 2021

it's got even worse since enabling the Spaces labs flag (and really screws up my demos)

@Palid
Copy link
Contributor

Palid commented Aug 16, 2021

This will be probably fixed by with element-hq/element-desktop#682

@deniseal
Copy link
Member

I am getting this on Element desktop version 1.8.1 on macOS Big Sur 11.5.2

It's quite regular, but it mainly happens when switching room and/or space

@ara4n
Copy link
Member Author

ara4n commented Aug 20, 2021

confirmed fixed by matrix-org/matrix-react-sdk#6262 - huge huge thanks to @Palid and @gsouquet :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants