Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New room pills are off-spec #16660

Closed
turt2live opened this issue Mar 11, 2021 · 4 comments · Fixed by matrix-org/matrix-react-sdk#5748
Closed

New room pills are off-spec #16660

turt2live opened this issue Mar 11, 2021 · 4 comments · Fixed by matrix-org/matrix-react-sdk#5748

Comments

@turt2live
Copy link
Member

Autocompleting a room should result in a plaintext version of the alias in the message body, not the room name.

@turt2live
Copy link
Member Author

Declaring this a release blocker because it breaks some bots.

@SimonBrandner
Copy link
Contributor

I've made a PR to revert this. But I am not exactly happy about it... :( Any reason the spec defines pills like this? It seemed to have been confusing to some users...

@turt2live
Copy link
Member Author

turt2live commented Mar 11, 2021

They're able to look however visually - it's just the plaintext body which is meant to stay as a room alias. It's largely to support non-rich clients.

Edit: the spec is strict about how they look in the actual event, but we can render it however we want (and should show the room name, imo)

@SimonBrandner
Copy link
Contributor

Ok, I see, thanks for the explanation! I'll try to figure out a way how to do this later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment