Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Element does not interpret markdown after first encountering a room pill #20565

Closed
ShadowJonathan opened this issue Jan 14, 2022 · 8 comments
Closed
Labels
A-Composer A-Pills O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Cannot-Reproduce X-Regression

Comments

@ShadowJonathan
Copy link
Contributor

Steps to reproduce

Trying to send the following message;

image

Results in the following message;

image

Source
{
  "type": "m.room.message",
  "content": {
    "msgtype": "m.text",
    "body": "#matrix-spec:matrix.org a *thing*",
    "format": "org.matrix.custom.html",
    "formatted_body": "<a href=\"https://matrix.to/#/#matrix-spec:matrix.org\">#matrix-spec:matrix.org</a> a _thing_"
  }
}

Outcome

What did you expect?

Markdown to get interpreted correctly

What happened instead?

Markdown somehow got interpreted from HTML back to Markdown

Operating system

PopOS Linux, 21.04

Application version

Element version: 1.9.8 Olm version: 3.2.8

How did you install the app?

Flatpak

Homeserver

jboi.nl

Will you send logs?

No

@UwUnyaa
Copy link

UwUnyaa commented Jan 14, 2022

I just managed to reproduce this with element web (running as element desktop) 1.9.8-1 on Arch.

@UwUnyaa
Copy link

UwUnyaa commented Jan 14, 2022

Looking through code, I found a reference to this issue: #16660

@SimonBrandner
Copy link
Contributor

I don't think I can repro on develop.element.io

@SimonBrandner SimonBrandner added A-Composer A-Pills X-Cannot-Reproduce X-Regression S-Minor Impairs non-critical functionality or suitable workarounds exist O-Occasional Affects or can be seen by some users regularly or most users rarely labels Jan 15, 2022
@ShadowJonathan
Copy link
Contributor Author

ShadowJonathan commented Jan 15, 2022

I can reproduce it still on develop:

pill_repro-2022-01-15_13.54.50.mp4

@UwUnyaa
Copy link

UwUnyaa commented Jan 15, 2022

@SimonBrandner the ability to complete rooms in a given room is flaky, so for some reason this cannot be reproduced in every room, and doesn't seem to work at all in DMs.

@robintown
Copy link
Member

Probably a duplicate of #20091, since pills are actually links.

@ShadowJonathan
Copy link
Contributor Author

Indeed

Duplicate of #20091

@UwUnyaa
Copy link

UwUnyaa commented Jan 15, 2022

This would make sense, as mentions of users are considered to be pills, but don't cause the problem. It suggests that the problem is caused by something else entirely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Composer A-Pills O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Cannot-Reproduce X-Regression
Projects
None yet
Development

No branches or pull requests

4 participants