Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3PID invites #419

Closed
ara4n opened this issue Nov 24, 2015 · 9 comments
Closed

3PID invites #419

ara4n opened this issue Nov 24, 2015 · 9 comments
Assignees

Comments

@ara4n
Copy link
Member

ara4n commented Nov 24, 2015

Related: #529

@ara4n ara4n modified the milestone: Ragnarok Nov 29, 2015
@kegsay kegsay self-assigned this Dec 7, 2015
@kegsay
Copy link
Contributor

kegsay commented Dec 7, 2015

Blocked on https://matrix.org/jira/browse/SYN-540

@ara4n ara4n modified the milestones: Ragnarok, v0 Dec 13, 2015
@kegsay
Copy link
Contributor

kegsay commented Dec 14, 2015

Background:

  • Client types in https URL for identity server, and client persists it.
  • Client uses this for registration / 3PID linking.
  • This URL cannot be used for 3PID invites.

So I was told to do the same request without https:// and it Should Work which isn't the most helpful thing ever. This is because HS -> IS traffic is always https so the protocol portion of the URI is redundant/ignored. I don't think clients should be responsible for maintaining two different representations of identity servers just because https is "mandated" on HS -> IS; it's a horrible leaky abstraction currently.

In the interest of speed however, I'll just bite the bullet and strip the protocol so this bug can be resolved, but I don't have to like it.

@kegsay kegsay removed the X-Blocked label Dec 14, 2015
@kegsay
Copy link
Contributor

kegsay commented Dec 15, 2015

After doing this, I now get 401d...

@kegsay
Copy link
Contributor

kegsay commented Dec 15, 2015

Blocked on Synapse working as intended.

@kegsay
Copy link
Contributor

kegsay commented Dec 15, 2015

So you can now invite users on 3PID if they have already linked their account, but now getting 500d if they do not have a Matrix account.

@kegsay
Copy link
Contributor

kegsay commented Dec 15, 2015

So this is now fixed but I'm not getting an email to say I've been invited to a room..

@kegsay
Copy link
Contributor

kegsay commented Dec 16, 2015

Blocked waiting for invites to send emails.

@kegsay kegsay changed the title 3PID invites cause 500 errors... 3PID invites Dec 16, 2015
@kegsay
Copy link
Contributor

kegsay commented Dec 16, 2015

Need to:

@kegsay
Copy link
Contributor

kegsay commented Dec 17, 2015

Fixed mentioned issues. See #529 for follow-on work post-v0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants