Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to git protocol for CI deps #9221

Closed
jryans opened this issue Mar 20, 2019 · 1 comment
Closed

Switch to git protocol for CI deps #9221

jryans opened this issue Mar 20, 2019 · 1 comment
Assignees
@jryans
Labels
T-Task Tasks for the team like planning

Comments

@jryans
Copy link
Collaborator

jryans commented Mar 20, 2019

It will abort quickly when a repo doesn't exist, as opposed to https which hangs forever.
@jryans jryans self-assigned this Mar 20, 2019
jryans added a commit to jryans/matrix-react-sdk that referenced this issue Mar 20, 2019
@jryans
Switch to git protocol for CI dependencies
38c6767 
If you try to clone a repo that doesn't exist via `https`, `git` will prompt for
auth credentials and hang forever. Using `git` avoids this and fails immediately
instead, which is what we want for a missing repo.

Part of element-hq/element-web#9221
jryans added a commit to jryans/element-web that referenced this issue Mar 20, 2019
@jryans
Switch to git protocol for CI dependencies
8f646b3 
If you try to clone a repo that doesn't exist via `https`, `git` will prompt for
auth credentials and hang forever. Using `git` avoids this and fails immediately
instead, which is what we want for a missing repo.

Part of element-hq#9221
jryans added a commit to jryans/element-web that referenced this issue Mar 20, 2019
@jryans
Switch to git protocol for CI dependencies
52ad757 
If you try to clone a repo that doesn't exist via `https`, `git` will prompt for
auth credentials and hang forever. Using `git` avoids this and fails immediately
instead, which is what we want for a missing repo.

Part of element-hq#9221
jryans added a commit to jryans/matrix-react-sdk that referenced this issue Mar 20, 2019
@jryans
Switch to git protocol for CI dependencies
6f79e85 
If you try to clone a repo that doesn't exist via `https`, `git` will prompt for
auth credentials and hang forever. Using `git` avoids this and fails immediately
instead, which is what we want for a missing repo.

Part of element-hq/element-web#9221
This was referenced Mar 20, 2019
Merged
Merged
@jryans
Copy link
Collaborator Author

jryans commented Mar 20, 2019

Fixed by matrix-org/matrix-react-sdk#2809 and #9222.

@jryans jryans closed this as completed Mar 20, 2019
@jryans jryans added the T-Task Tasks for the team like planning label Mar 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jryans jryans

Labels
T-Task Tasks for the team like planning
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jryans