Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Message editing: support editing pending messages #9860

Closed
bwindels opened this issue May 28, 2019 · 1 comment
Closed

Message editing: support editing pending messages #9860

bwindels opened this issue May 28, 2019 · 1 comment

Comments

@bwindels
Copy link
Contributor

No description provided.

@bwindels
Copy link
Contributor Author

bwindels commented May 28, 2019

we'd need to emit edit_event with the fake id and listen for Room.localEchoUpdated and reemit edit_event with real event id ... all this without losing the editor internal state 🥴

Also, we can't send the edit until we have a real event id. Should we disable the save button or just queue (1) edit(s)? I guess the normal send queue would be good for this, but we need to modify the replacement event with the real event id after it has gone into the queue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants