Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editing with arrow-up doesn't take last message in room into account #9864

Closed
bwindels opened this issue May 28, 2019 · 6 comments · Fixed by matrix-org/matrix-react-sdk#3097

Comments

@bwindels
Copy link
Contributor

probably 1-off error in findEditableEvent fn

@bwindels
Copy link
Contributor Author

can't reproduce anymore now ... should have attached a GIF when I had it happening to see if any of the messages had anything special about them.

@lampholder
Copy link
Member

We can leave this open incase anyone else sees it

@anoadragon453
Copy link
Member

I get this regularly, but it might be a slightly different problem, in that it'll only occur for about 2s after I send a message. After a little bit, Riot figures out that the message I just sent is the one I want to edit.

And yes this occurs a bit after the message has been indicated as sent.

@bwindels
Copy link
Contributor Author

bwindels commented Jun 3, 2019

Hmm, interesting. Might not be re-rerending if the order of events is wrong. Let's see if this is still a problem once #9860 is implemented.

@turt2live
Copy link
Member

That sounds like the same problem I run into. The send request succeeds, but sync hasn't picked up on it yet.

@bwindels
Copy link
Contributor Author

bwindels commented Jun 12, 2019

my guess is that this happens when an event has been sent but the remote echo hasn't been received yet. In this case, it's not in the timeline collection yet, still in the pending event list, which wasn't taken into account so far to edit.

E.g. what Travis said 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants